Re: [PATCH] drm: Destroy property blobs at mode config cleanup time

From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: Destroy property blobs at mode config cleanup time
Date: Mon, 18 Mar 2013 10:43:49 +0100	[thread overview]
Message-ID: <2433255.P48q2sdkb2@avalon> (raw)
In-Reply-To: <20130318080621.GM9021@phenom.ffwll.local>

Hi Daniel,

On Monday 18 March 2013 09:06:21 Daniel Vetter wrote:
> On Tue, Mar 12, 2013 at 03:31:11PM +0100, Laurent Pinchart wrote:
> > Property blob objects need to be destroyed when cleaning up to avoid
> > memory leaks. Go through the list of all blobs in the
> > drm_mode_config_cleanup() function and destroy them.
> > 
> > The drm_mode_config_cleanup() function needs to be moved after the
> > drm_property_destroy_blob() declaration. Move drm_mode_config_init() as
> > well to keep the functions together.
> 
> Imo moving drm_mode_config_init looks a bit superflous in this patch,
> since there's still some other init code left around at the old place.

It's not mandatory indeed, but it's a step in the right direction in my 
opinion. Maybe a separate patch that just moves functions around in drm_crtc.c 
would be a better idea :-)

> Drop that code movement?

I have no strong opinion, I can drop it if that's preferred.

> Otherwise Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Thank you.

-- 
Regards,

Laurent Pinchart