From: Ian Jackson <iwj@xenproject.org>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Wei Liu" <wl@xen.org>, "Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH v2 2/2] tools/x86: move arch-specific include/xen/ population into arch-specific rule
Date: Fri, 12 Mar 2021 10:24:56 +0000 [thread overview]
Message-ID: <24651.16760.951727.831368@mariner.uk.xensource.com> (raw)
In-Reply-To: <e6bcfa87-aa12-97dd-23f4-d2f085e2e4f6@suse.com>
Jan Beulich writes ("[PATCH v2 2/2] tools/x86: move arch-specific include/xen/ population into arch-specific rule"):
> There's no need for the common "xen-dir" rule to have an arch-specific
> part when there already is a arch-specific rule where this can be taken
> care of (arguably instead of all-y this might better be xendir-y
> anyway).
Thanks, but I do not like this change.
IMO make commands should be primarily organised by their logical
function and role in the file. If that means that multiple targets
have arch-specific parts, so be it.
IMO it is not right to move something from xen-dir to all just to
reduce the number of different targets with arch-specific parts.
Ian.
next prev parent reply other threads:[~2021-03-12 10:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 14:38 [PATCH v2 0/2] tools/x86: adjust populating of tools/include/xen/ Jan Beulich
2021-03-11 14:40 ` [PATCH v2 1/2][4.15] tools/x86: don't rebuild cpuid-autogen.h every time Jan Beulich
2021-03-11 15:29 ` Roger Pau Monné
2021-03-11 16:00 ` Jan Beulich
2021-03-11 16:21 ` Roger Pau Monné
2021-03-12 8:45 ` Jan Beulich
2021-03-12 9:17 ` Roger Pau Monné
2021-03-12 9:22 ` Jan Beulich
2021-03-12 10:22 ` Ian Jackson
2021-03-11 14:40 ` [PATCH v2 2/2] tools/x86: move arch-specific include/xen/ population into arch-specific rule Jan Beulich
2021-03-12 10:24 ` Ian Jackson [this message]
2021-03-12 16:50 ` [PATCH v3][4.15] tools/x86: don't rebuild cpuid-autogen.h every time Jan Beulich
2021-03-12 16:59 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24651.16760.951727.831368@mariner.uk.xensource.com \
--to=iwj@xenproject.org \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.