From: Ian Jackson <iwj@xenproject.org>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"Wei Liu" <wl@xen.org>, "Roger Pau Monné" <roger.pau@citrix.com>,
committers@xenproject.org
Subject: Re: [PATCH v4 0/2][4.15] x86: guest MSR access handling tweaks [and 1 more messages]
Date: Fri, 12 Mar 2021 13:59:33 +0000 [thread overview]
Message-ID: <24651.29637.673344.425436@mariner.uk.xensource.com> (raw)
In-Reply-To: <9c2e5e0e-041f-03e3-3c08-7abcc82d63c7@suse.com>, <7504b027-f106-33e1-214a-eecf8ea5ff5d@citrix.com>
Jan Beulich writes ("[PATCH v4 0/2][4.15] x86: guest MSR access handling tweaks"):
> Largely to re-base patch 1.
>
> 1: PV: conditionally avoid raising #GP for early guest MSR reads
> 2: AMD: expose HWCR.TscFreqSel to guests
Jan, thanks for the v4. Roger, thanks for your reviews and for your
mail to committers@ (on Wednesday).
Andrew Cooper writes ("Re: [PATCH v3 1/2][4.15] x86/PV: conditionally avoid raising #GP for early guest MSR reads"):
> I am still of the firm belief that this is the wrong course of action.
Andrew, thanks for your clearly stated opinion.
It seems to me that, even having taken Andrew's strong objection into
account, Jan and Roger and I all still think this patch is the right
thing to do.
With my release manager hat on I would prefer not to spend any more
time debating this; and, the discussions do not seem to be producing
any new information.
I spoke to Jan on IRC and he confirmed that these patches are finished
on a detailed technical level - that is, there is no reason not to
commit these patches, except for the above objection to the whole
principle.
I therefore intend to commit both these two patches (v4) late this
afternoon, say 5pm UK time. If anyone thinks that this would be
improper, or has a new reason I shouldn't go ahead, please let me know
ASAP.
Thanks,
Ian.
next prev parent reply other threads:[~2021-03-12 13:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 7:53 [PATCH v3 0/2][4.15] x86: guest MSR access handling tweaks Jan Beulich
2021-03-12 7:54 ` [PATCH v3 1/2][4.15] x86/PV: conditionally avoid raising #GP for early guest MSR reads Jan Beulich
2021-03-12 9:08 ` Roger Pau Monné
2021-03-12 9:32 ` Jan Beulich
2021-03-12 11:19 ` Andrew Cooper
2021-03-12 11:01 ` [PATCH v4 0/2][4.15] x86: guest MSR access handling tweaks Jan Beulich
2021-03-12 11:02 ` [PATCH v4 1/2][4.15] x86/PV: conditionally avoid raising #GP for early guest MSR reads Jan Beulich
2021-03-12 11:03 ` [PATCH v4 2/2][4.15] x86/AMD: expose HWCR.TscFreqSel to guests Jan Beulich
2021-03-12 13:59 ` Ian Jackson [this message]
2021-03-12 13:34 ` [PATCH v3 1/2][4.15] x86/PV: conditionally avoid raising #GP for early guest MSR reads Jan Beulich
2021-03-12 7:55 ` [PATCH v3 2/2][4.15] x86/AMD: expose HWCR.TscFreqSel to guests Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24651.29637.673344.425436@mariner.uk.xensource.com \
--to=iwj@xenproject.org \
--cc=andrew.cooper3@citrix.com \
--cc=committers@xenproject.org \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.