Re: [PATCH 1/6] qla2xxx: Fix message indicating vectors used by driver

From: Lee Duncan <LDuncan@suse.com>
To: Himanshu Madhani <hmadhani@marvell.com>,
	"James.Bottomley@HansenPartnership.com" 
	<James.Bottomley@HansenPartnership.com>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 1/6] qla2xxx: Fix message indicating vectors used by driver
Date: Wed, 4 Sep 2019 22:33:39 +0000	[thread overview]
Message-ID: <2589c49d-fe93-de98-b141-e1ee3e98e46b@suse.com> (raw)
In-Reply-To: <20190830222402.23688-2-hmadhani@marvell.com>

On 8/30/19 3:23 PM, Himanshu Madhani wrote:
> This patch updates log message which indicates number
> of vectors used by driver instead of displaying failure
> to get maximum requested vectors. Driver will always
> request maximum vectors during initialization. In the
> event driver is not able to get maximum requested vectors,
> it will adjust the allocated vectors. This is normal and
> does not imply failure in driver.
> 
> Signed-off-by: Himanshu Madhani <hmadhani@marvell.com>
> ---
>  drivers/scsi/qla2xxx/qla_isr.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
> index d81b5ecce24b..4c26630c1c3e 100644
> --- a/drivers/scsi/qla2xxx/qla_isr.c
> +++ b/drivers/scsi/qla2xxx/qla_isr.c
> @@ -3466,10 +3466,8 @@ qla24xx_enable_msix(struct qla_hw_data *ha, struct rsp_que *rsp)
>  		    ha->msix_count, ret);
>  		goto msix_out;
>  	} else if (ret < ha->msix_count) {
> -		ql_log(ql_log_warn, vha, 0x00c6,
> -		    "MSI-X: Failed to enable support "
> -		     "with %d vectors, using %d vectors.\n",
> -		    ha->msix_count, ret);
> +		ql_log(ql_log_info, vha, 0x00c6,
> +		    "MSI-X: Using %d vectors\n", ret);
>  		ha->msix_count = ret;
>  		/* Recalculate queue values */
>  		if (ha->mqiobase && (ql2xmqsupport || ql2xnvmeenable)) {
> 

Reviewed-by: Lee Duncan <lduncan@suse.com>