From: Hans de Goede <hdegoede@redhat.com>
To: Mark Brown <broonie@kernel.org>
Cc: Oder Chiou <oder_chiou@realtek.com>,
Cezary Rojewski <cezary.rojewski@intel.com>,
alsa-devel@alsa-project.org, Jie Yang <yang.jie@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>
Subject: Re: [PATCH 5/6] ASoC: rt5670: Remove struct rt5670_platform_data
Date: Mon, 29 Jun 2020 22:24:01 +0200 [thread overview]
Message-ID: <25d7879e-8e6e-40db-78eb-c8dc150d6264@redhat.com> (raw)
In-Reply-To: <20200629200904.GK5499@sirena.org.uk>
Hi,
On 6/29/20 10:09 PM, Mark Brown wrote:
> On Sun, Jun 28, 2020 at 05:52:30PM +0200, Hans de Goede wrote:
>> platform_data is an obsolete concept, instead device_properties,
>> set through e.g. device-tree, should be used.
>>
>> struct rt5670_platform_data is only used internally by the rt5670 codec
>> driver, so lets remove it before someone starts relying on it.
>
> This doesn't apply against current code, please check and resend.
Did you try to apply this to your for-5.9 branch (I know that was
my own suggestion) ? I must admit I did not think this through,
this patch depends on some of the changes made in patches 1-4 :|
So either you could add patches 5 and 6 to your for-5.8 branch too,
or it might be best to delay these 2 till after 5.9-rc1 otherwise
we are going to get a merge conflict.
Regards,
Hans
next prev parent reply other threads:[~2020-06-29 20:25 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-28 15:52 ASoC: rt5670/cht_bsw_rt5672: Some bugfixes and cleanups Hans de Goede
2020-06-28 15:52 ` [PATCH 1/6] ASoC: Intel: cht_bsw_rt5672: Change bus format to I2S 2 channel Hans de Goede
2020-06-29 15:06 ` Pierre-Louis Bossart
2020-06-29 19:38 ` Mark Brown
2020-06-29 19:38 ` Mark Brown
2020-07-01 19:33 ` Sasha Levin
2020-07-01 19:33 ` Sasha Levin
2020-07-01 19:46 ` Pierre-Louis Bossart
2020-07-03 8:28 ` Hans de Goede
2020-07-03 17:03 ` Mark Brown
2020-07-10 14:02 ` Sasha Levin
2020-07-10 14:02 ` Sasha Levin
2020-06-28 15:52 ` [PATCH 2/6] ASoC: rt5670: Correct RT5670_LDO_SEL_MASK Hans de Goede
2020-06-28 15:52 ` [PATCH 3/6] ASoC: rt5670: Add new gpio1_is_ext_spk_en quirk and enable it on the Lenovo Miix 2 10 Hans de Goede
2020-06-28 15:52 ` [PATCH 4/6] ASoC: rt5670: Fix dac- and adc- vol-tlv values being off by a factor of 10 Hans de Goede
2020-06-29 15:10 ` Pierre-Louis Bossart
2020-06-28 15:52 ` [PATCH 5/6] ASoC: rt5670: Remove struct rt5670_platform_data Hans de Goede
2020-06-29 20:09 ` Mark Brown
2020-06-29 20:24 ` Hans de Goede [this message]
2020-06-29 21:01 ` Mark Brown
2020-06-28 15:52 ` [PATCH 6/6] ASoC: rt5670: Rename dev_gpio to gpio1_is_irq Hans de Goede
2020-06-29 15:14 ` ASoC: rt5670/cht_bsw_rt5672: Some bugfixes and cleanups Pierre-Louis Bossart
2020-06-29 20:02 ` Hans de Goede
2020-06-29 20:07 ` Mark Brown
2020-06-29 20:19 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25d7879e-8e6e-40db-78eb-c8dc150d6264@redhat.com \
--to=hdegoede@redhat.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=oder_chiou@realtek.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.