From: Jens Axboe <axboe@kernel.dk>
To: Zhang Wensheng <zhangwensheng5@huawei.com>, josef@toxicpanda.com
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
nbd@other.debian.org
Subject: Re: [PATCH -next] nbd: fix possible overflow on 'first_minor' in nbd_dev_add()
Date: Wed, 6 Apr 2022 06:55:32 -0600 [thread overview]
Message-ID: <263199dd-34e4-36ff-51ef-23a8f4bbe5b2@kernel.dk> (raw)
In-Reply-To: <20220406112449.2203191-1-zhangwensheng5@huawei.com>
On 4/6/22 5:24 AM, Zhang Wensheng wrote:
> When 'index' is a big numbers, it may become negative which forced
> to 'int'. then 'index << part_shift' might overflow to a positive
> value that is not greater than '0xfffff', then sysfs might complains
> about duplicate creation. Because of this, move the 'index' judgment
> to the front will fix it and be better.
What's changed in this version? Always add a v2 to both the subject
line and below the '---' so that folks reviewing this will know
what changes you made since the last posting.
--
Jens Axboe
next prev parent reply other threads:[~2022-04-06 15:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 11:24 [PATCH -next] nbd: fix possible overflow on 'first_minor' in nbd_dev_add() Zhang Wensheng
2022-04-06 12:55 ` Jens Axboe [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-03-10 9:32 Zhang Wensheng
2022-03-11 2:43 ` zhangwensheng (E)
2022-03-17 13:05 ` zhangwensheng (E)
2022-03-31 0:45 ` zhangwensheng (E)
2022-03-31 14:07 ` Josef Bacik
2022-03-31 14:30 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=263199dd-34e4-36ff-51ef-23a8f4bbe5b2@kernel.dk \
--to=axboe@kernel.dk \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nbd@other.debian.org \
--cc=zhangwensheng5@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.