From: David Howells <dhowells@redhat.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: dhowells@redhat.com, linux-fsdevel@vger.kernel.org,
linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org,
linux-ext4@vger.kernel.org, linux-mm@kvack.org,
Hugh Dickins <hughd@google.com>,
linux-kernel@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH 4/5] afs: Zero bytes after 'oldsize' if we're expanding the file
Date: Mon, 27 Feb 2023 14:49:59 +0000 [thread overview]
Message-ID: <2736267.1677509399@warthog.procyon.org.uk> (raw)
In-Reply-To: <Y/y5rFX2koj2W6Wa@casper.infradead.org>
Matthew Wilcox <willy@infradead.org> wrote:
> I'll send a patch series with all of this; it doesn't seem terribly
> urgent. Do you think there's a similar problem for AFS that Brian
> noted with the generic patch?
Probably not. To avoid deadlocking itself, afs uses a mutex to prevent
writepages racing with truncate (vnode->validate_lock).
commit ec0fa0b659144d9c68204d23f627b6a65fa53e50
afs: Fix deadlock between writeback and truncate
the afs_setattr_edit_file() call that changes i_size and partially clears the
pagecache is applied to the local inode before the mutex is dropped.
David
prev parent reply other threads:[~2023-02-27 14:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-02 20:44 [PATCH 0/5] Fix a minor POSIX conformance problem Matthew Wilcox (Oracle)
2023-02-02 20:44 ` [PATCH 1/5] truncate: Zero bytes after 'oldsize' if we're expanding the file Matthew Wilcox (Oracle)
2023-02-03 13:00 ` Brian Foster
2023-02-03 15:07 ` Matthew Wilcox
2023-02-02 20:44 ` [PATCH 2/5] ext4: " Matthew Wilcox (Oracle)
2023-02-02 20:44 ` [PATCH 3/5] tmpfs: " Matthew Wilcox (Oracle)
2023-02-02 20:44 ` [PATCH 4/5] afs: " Matthew Wilcox (Oracle)
2023-02-02 20:44 ` [PATCH 5/5] btrfs: " Matthew Wilcox (Oracle)
2023-02-02 20:44 ` [PATCH 6/5] generic: test ftruncate zeroes bytes after EOF Matthew Wilcox (Oracle)
2023-02-03 11:57 ` Johannes Thumshirn
2023-02-03 13:13 ` Matthew Wilcox
2023-02-03 16:35 ` Darrick J. Wong
2023-02-02 23:08 ` [PATCH 0/5] Fix a minor POSIX conformance problem Andreas Dilger
2023-02-03 13:21 ` Matthew Wilcox
2023-02-03 16:23 ` David Laight
2023-02-03 16:29 ` Matthew Wilcox
2023-02-27 13:49 ` [PATCH 4/5] afs: Zero bytes after 'oldsize' if we're expanding the file David Howells
2023-02-27 14:09 ` Matthew Wilcox
2023-02-27 14:20 ` David Howells
2023-02-27 14:49 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2736267.1677509399@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=hughd@google.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.