All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Andrew Jones <drjones@redhat.com>, kvm@vger.kernel.org
Cc: pbonzini@redhat.com, rkrcmar@redhat.com, lvivier@redhat.com
Subject: Re: [PATCH kvm-unit-tests 2/2] arm/arm64: gic: apply report_prefix_pushf
Date: Mon, 22 May 2017 22:09:35 +0200	[thread overview]
Message-ID: <2769e3a5-d6e8-8486-18d1-cc799cc31a66@redhat.com> (raw)
In-Reply-To: <20170522181821.29482-3-drjones@redhat.com>

On 22.05.2017 20:18, Andrew Jones wrote:
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
>  arm/gic.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/arm/gic.c b/arm/gic.c
> index 82f663218b0b..e27e8a36a9f0 100644
> --- a/arm/gic.c
> +++ b/arm/gic.c
> @@ -297,7 +297,6 @@ static void run_active_clear_test(void)
>  
>  int main(int argc, char **argv)
>  {
> -	char pfx[8];
>  	int cpu;
>  
>  	if (!gic_init()) {
> @@ -305,8 +304,7 @@ int main(int argc, char **argv)
>  		return report_summary();
>  	}
>  
> -	snprintf(pfx, sizeof(pfx), "gicv%d", gic_version());
> -	report_prefix_push(pfx);
> +	report_prefix_pushf("gicv%d", gic_version());
>  
>  	switch (gic_version()) {
>  	case 2:
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>

  reply	other threads:[~2017-05-22 20:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-22 18:18 [PATCH kvm-unit-tests 0/2] apply some new lib functions Andrew Jones
2017-05-22 18:18 ` [PATCH kvm-unit-tests 1/2] arm/powerpc: setup: apply assert_msg Andrew Jones
2017-05-22 20:05   ` Thomas Huth
2017-05-22 18:18 ` [PATCH kvm-unit-tests 2/2] arm/arm64: gic: apply report_prefix_pushf Andrew Jones
2017-05-22 20:09   ` Thomas Huth [this message]
2017-05-25 16:36 ` [PATCH kvm-unit-tests 0/2] apply some new lib functions Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2769e3a5-d6e8-8486-18d1-cc799cc31a66@redhat.com \
    --to=thuth@redhat.com \
    --cc=drjones@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=rkrcmar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.