RE: [PATCH 0/9] dspbridge cleanup patches

From: "Ramirez Luna, Omar" <omar.ramirez@ti.com>
To: "Menon, Nishanth" <nm@ti.com>
Cc: Felipe Contreras <felipe.contreras@gmail.com>,
	"dedekind1@gmail.com" <dedekind1@gmail.com>,
	linux-omap <linux-omap@vger.kernel.org>,
	Hiroshi Doyu <Hiroshi.DOYU@nokia.com>
Subject: RE: [PATCH 0/9] dspbridge cleanup patches
Date: Wed, 25 Nov 2009 15:52:48 -0600	[thread overview]
Message-ID: <27F9C60D11D683428E133F85D2BB4A530426F26833@dlee03.ent.ti.com> (raw)
In-Reply-To: <4B0D99F2.5020006@ti.com>

>From: Menon, Nishanth
>Subject: Re: [PATCH 0/9] dspbridge cleanup patches
>
>> 1. http://dev.omapzoom.org/?p=tidspbridge/kernel-
>dspbridge.git;a=commit;h=b6b7bc5b620596790b2ea26225908b3cf62c36be
>
>How about the discussion in
>http://marc.info/?l=linux-omap&m=123728293826758&w=2 ?
>same arguments seem valid now..
>

Opps, sorry about that, seems like I stole/redid your patch Felipe, I'll diff it (to see nothing is missing), fix author and add my signed off.

Nishant,

I actually removed the history because one of your comments:
[snip]
> > + * GPIO Module disable when not in use - Charulatha V 
> > + <charu@ti.com>
> Please stop adding history here.. git commit is supposed to contain 
> it. No stats are generated from looking at file history anymore and 
> there is definitely the risk of getting as big as
> http://dev.omapzoom.org/?p=tidspbridge/kernel-
> dspbridge.git;a=blob;f=drivers/dsp/bridge/rmgr/mgr.c;h=943cf932a35b75f
> 709f
> 554deb3c51c47088d8b78;hb=refs/heads/dspbridge#l26
[snip]

Personally, If any folk mentioned on the removed history disagrees, it is welcome to send a mail to this mailing list detailing his contributions and I guess someone (me, most likely) will check on it. For now a line thanking "vp", "rr", "sp" etc. for their initial work will be added to the patch.

>>
>> 3. http://dev.omapzoom.org/?p=tidspbridge/kernel-
>dspbridge.git;a=commit;h=b4d73d15bd2b1c7dd1cc89ca9e81a98946ddf241
>printk(KERN_ERR ?? why not use the pr_err/warning/info family?
>

My git:
 drivers/dsp/bridge/rmgr/dbdcd.c         |  165 +++-----
 drivers/dsp/bridge/rmgr/disp.c          |  254 ++++-------
 drivers/dsp/bridge/rmgr/drv.c           |  399 +++++++----------
 drivers/dsp/bridge/rmgr/drv_interface.c |   92 ++---
 drivers/dsp/bridge/rmgr/dspdrv.c        |   34 +-
 drivers/dsp/bridge/rmgr/proc.c          |  754 ++++++++++++++-----------------
 drivers/dsp/bridge/rmgr/rmm.c           |   46 +--
 drivers/dsp/bridge/rmgr/strm.c          |  144 +++----
 8 files changed, 791 insertions(+), 1097 deletions(-)

(now): Removing GT_Trace wrappers and replacing for pr_debug

- omar