From: "Ramirez Luna, Omar" <omar.ramirez@ti.com>
To: Ameya Palande <ameya.palande@nokia.com>, "Menon, Nishanth" <nm@ti.com>
Cc: linux-omap <linux-omap@vger.kernel.org>,
"Chitriki Rudramuni, Deepak" <deepak.chitriki@ti.com>,
"Contreras Felipe (Nokia-D/Helsinki)"
<felipe.contreras@nokia.com>,
"Doyu Hiroshi (Nokia-D/Helsinki)" <hiroshi.doyu@nokia.com>
Subject: RE: [PATCH] DSPBRIDGE: replace init_timer with init_timer_on_stack
Date: Wed, 20 Jan 2010 16:53:39 -0600 [thread overview]
Message-ID: <27F9C60D11D683428E133F85D2BB4A53042DF3B22C@dlee03.ent.ti.com> (raw)
In-Reply-To: <1263981303.2066.2.camel@sanganak>
>From: Ameya Palande on Wednesday, January 20, 2010 3:55 AM
>
>On Wed, 2010-01-20 at 01:45 +0100, ext Nishanth Menon wrote:
>> With LOCK_DEP enabled and DEBUG_OBJECTS_TIMERS, DSPBridge
>> SYNC_WaitOnMultipleEvents will fail with message
>> "ODEBUG: object is on stack, but not annotated"
>> since the timeout timer is on the stack, we should rightly use
>> init_timer_on_stack.
>>
>> Cc: Ameya Palande <ameya.palande@nokia.com>
>> Cc: Deepak Chitriki <deepak.chitriki@ti.com>
>> Cc: Felipe Contreras <felipe.contreras@nokia.com>
>> Cc: Hiroshi Doyu <hiroshi.doyu@nokia.com>
>> Cc: Omar Ramirez Luna <omar.ramirez@ti.com>
>>
>> Signed-off-by: Nishanth Menon <nm@ti.com>
>> ---
>> drivers/dsp/bridge/services/sync.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/dsp/bridge/services/sync.c b/drivers/dsp/bridge/services/sync.c
>> index c2d79c7..d246656 100644
>> --- a/drivers/dsp/bridge/services/sync.c
>> +++ b/drivers/dsp/bridge/services/sync.c
>> @@ -330,7 +330,7 @@ DSP_STATUS SYNC_WaitOnMultipleEvents(struct SYNC_OBJECT **hSyncEvents,
>> if (Wp->state != wo_signalled && dwTimeout > 0) {
>> struct timer_list timeout;
>> if (dwTimeout != SYNC_INFINITE) {
>> - init_timer(&timeout);
>> + init_timer_on_stack(&timeout);
>> timeout.function = timeout_callback;
>> timeout.data = (unsigned long)Wp;
>> timeout.expires = jiffies + dwTimeout * HZ / 1000;
>
>Acked-by: Ameya Palande <ameya.palande@nokia.com>
Pushed to dspbridge
- omar
prev parent reply other threads:[~2010-01-20 22:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-20 0:45 [PATCH] DSPBRIDGE: replace init_timer with init_timer_on_stack Nishanth Menon
2010-01-20 9:55 ` Ameya Palande
2010-01-20 22:53 ` Ramirez Luna, Omar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27F9C60D11D683428E133F85D2BB4A53042DF3B22C@dlee03.ent.ti.com \
--to=omar.ramirez@ti.com \
--cc=ameya.palande@nokia.com \
--cc=deepak.chitriki@ti.com \
--cc=felipe.contreras@nokia.com \
--cc=hiroshi.doyu@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.