From: "Arce, Abraham" <x0066660@ti.com>
To: "Pandita, Vikram" <vikram.pandita@ti.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: RE: [RFC] [PATCH v2 3/4] OMAP4: Keyboard board support
Date: Thu, 13 May 2010 23:01:45 -0500 [thread overview]
Message-ID: <27F9C60D11D683428E133F85D2BB4A53043E113DD9@dlee03.ent.ti.com> (raw)
In-Reply-To: <FCCFB4CDC6E5564B9182F639FC35608703050DEF02@dbde02.ent.ti.com>
Vikram,
> From: Pandita, Vikram
[..]
> >+
> >+struct omap_device *od;
>
> Any reason to have this global?
Not really... I'll change it local to the keyboard init function, thanks!
Best Regards
Abraham
prev parent reply other threads:[~2010-05-14 4:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-13 20:50 [RFC] [PATCH v2 3/4] OMAP4: Keyboard board support Arce, Abraham
2010-05-14 2:55 ` Pandita, Vikram
2010-05-14 4:01 ` Arce, Abraham [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27F9C60D11D683428E133F85D2BB4A53043E113DD9@dlee03.ent.ti.com \
--to=x0066660@ti.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=vikram.pandita@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.