From: Bart Van Assche <bvanassche@acm.org>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: Damien Le Moal <dlemoal@kernel.org>, linux-block@vger.kernel.org
Subject: Re: [PATCH 4/7] blk-mq: use the I/O scheduler for writes from the flush state machine
Date: Fri, 19 May 2023 12:44:19 -0700 [thread overview]
Message-ID: <27e6ec54-cd3d-0804-fde4-847182895b83@acm.org> (raw)
In-Reply-To: <20230519044050.107790-5-hch@lst.de>
On 5/18/23 21:40, Christoph Hellwig wrote:
> /*
> * Three pointers are available for the IO schedulers, if they need
> - * more they have to dynamically allocate it. Flush requests are
> - * never put on the IO scheduler. So let the flush fields share
> - * space with the elevator data.
> + * more they have to dynamically allocate it.
> */
(commenting on my own patch) How about adding the words "private data" in the
above comment to improve clarity? That will change the above comment into:
/*
* Three pointers are available for IO schedulers. If they need
* more private data they have to allocate it dynamically.
*/
next prev parent reply other threads:[~2023-05-19 19:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-19 4:40 less special casing for flush requests v2 Christoph Hellwig
2023-05-19 4:40 ` [PATCH 1/7] blk-mq: factor out a blk_rq_init_flush helper Christoph Hellwig
2023-05-19 18:54 ` Bart Van Assche
2023-05-19 4:40 ` [PATCH 2/7] blk-mq: reflow blk_insert_flush Christoph Hellwig
2023-05-19 19:38 ` Bart Van Assche
2023-05-19 4:40 ` [PATCH 3/7] blk-mq: defer to the normal submission path for non-flush flush commands Christoph Hellwig
2023-05-19 4:40 ` [PATCH 4/7] blk-mq: use the I/O scheduler for writes from the flush state machine Christoph Hellwig
2023-05-19 19:44 ` Bart Van Assche [this message]
2023-05-24 5:53 ` Christoph Hellwig
2023-05-24 18:07 ` Bart Van Assche
2023-05-25 8:14 ` Christoph Hellwig
2023-05-28 20:50 ` Bart Van Assche
2023-05-30 14:55 ` Christoph Hellwig
2023-05-31 13:34 ` Bart Van Assche
2023-05-31 15:00 ` Christoph Hellwig
2023-05-19 4:40 ` [PATCH 5/7] blk-mq: defer to the normal submission path for post-flush requests Christoph Hellwig
2023-05-19 19:42 ` Bart Van Assche
2023-05-19 4:40 ` [PATCH 6/7] blk-mq: do not do head insertions post-pre-flush commands Christoph Hellwig
2023-05-19 4:40 ` [PATCH 7/7] blk-mq: don't use the requeue list to queue flush commands Christoph Hellwig
2023-05-19 19:55 ` Bart Van Assche
2023-05-20 4:56 ` Christoph Hellwig
2023-05-21 14:06 ` Bart Van Assche
2023-05-20 1:53 ` less special casing for flush requests v2 Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27e6ec54-cd3d-0804-fde4-847182895b83@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.