From: Dylan Yudaken <dylany@fb.com>
To: "asml.silence@gmail.com" <asml.silence@gmail.com>,
"io-uring@vger.kernel.org" <io-uring@vger.kernel.org>
Cc: "axboe@kernel.dk" <axboe@kernel.dk>
Subject: Re: [PATCH for-next] io_uring: fix CQE reordering
Date: Fri, 23 Sep 2022 14:32:02 +0000 [thread overview]
Message-ID: <2815cf233c3171204823eda9a18f7c67894b7db9.camel@fb.com> (raw)
In-Reply-To: <ec3bc55687b0768bbe20fb62d7d06cfced7d7e70.1663892031.git.asml.silence@gmail.com>
On Fri, 2022-09-23 at 14:53 +0100, Pavel Begunkov wrote:
> Overflowing CQEs may result in reordeing, which is buggy in case of
> links, F_MORE and so.
>
Maybe the commit message got cut off?
I think this is probably ok, the downside being that CQE's with no
ordering constraints will have ordering forced on them. An alternative
would be for each case (eg linked, zerocopy, multishot) to either pause
or force CQE's to be overflow ones. This wouldnt slow down the other
codepaths. I don't have an idea for how difficult this might be.
By the way, if you do go with this approach then I believe you can
revert these patches:
a2da676376fe ("io_uring: fix multishot poll on overflow")
cbd25748545c ("io_uring: fix multishot accept ordering")
and do something similar for multishot receive.
Dylan
next prev parent reply other threads:[~2022-09-23 14:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 13:53 [PATCH for-next] io_uring: fix CQE reordering Pavel Begunkov
2022-09-23 14:19 ` Jens Axboe
2022-09-23 14:26 ` Pavel Begunkov
2022-09-23 14:35 ` Jens Axboe
2022-09-23 14:43 ` Pavel Begunkov
2022-09-23 14:51 ` Jens Axboe
2022-09-23 14:32 ` Dylan Yudaken [this message]
2022-09-23 14:34 ` Jens Axboe
2022-09-23 21:05 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2815cf233c3171204823eda9a18f7c67894b7db9.camel@fb.com \
--to=dylany@fb.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.