Re: [PATCH v3 0/2] log both average and max values over the window

From: Vincent Fu <vincentfu@gmail.com>
To: Ankit Kumar <ankit.kumar@samsung.com>, axboe@kernel.dk
Cc: fio@vger.kernel.org
Subject: Re: [PATCH v3 0/2] log both average and max values over the window
Date: Thu, 25 Jan 2024 09:11:59 -0500	[thread overview]
Message-ID: <2830529c-c441-4047-8bf5-02698d3fbb05@gmail.com> (raw)
In-Reply-To: <20240125110124.55137-1-ankit.kumar@samsung.com>

On 1/25/24 06:01, Ankit Kumar wrote:
> This series adds an alias log_window_value to option log_max_value which
> now report average, max or both the values. The log_window_value option
> type has been changed from boolean to string but retains backward
> compatibility by allowing =0 and =1 values to specify avg and max values
> respectively.
> There is no change to existing log formats while reporting only average
> or max values.
> 
> The fio documentation has been updated specifying the new log format
> when both values are reported.
> 
> Changes since v2:
>   - Fix man page as suggested by Vincent.
> 
> Changes since v1:
>   - Use posval for strings instead of magic numbers as suggested by
>     Jens.
>   - Change option name to log_window_value and add alias to log_max_value
>     as suggested by Vincent.
> 
> Ankit Kumar (2):
>    stat: log out both average and max over the window
>    docs: update fio man page for log_window_value
> 
>   HOWTO.rst | 45 +++++++++++++++++++++++++--------
>   client.c  |  6 +++--
>   fio.1     | 47 +++++++++++++++++++++++++++--------
>   iolog.c   | 74 ++++++++++++++++++++++++++++++++++++++++---------------
>   iolog.h   | 21 +++++++++++++---
>   options.c | 34 +++++++++++++++++++++----
>   server.c  |  6 +++--
>   stat.c    | 32 ++++++++++++++----------
>   8 files changed, 200 insertions(+), 65 deletions(-)
> 

Applied. Thanks.