From: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
To: "ardeleanalex@gmail.com" <ardeleanalex@gmail.com>,
"barbara.fernandes@usp.br" <barbara.fernandes@usp.br>
Cc: "melissa.srw@gmail.com" <melissa.srw@gmail.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"spoonm@spoonm.org" <spoonm@spoonm.org>
Subject: Re: [PATCH 1/2] staging: iio: cdc: ad7150: create of_device_id array
Date: Mon, 20 May 2019 10:20:58 +0000 [thread overview]
Message-ID: <28948637968846e814ac507a34c1886668d87ed7.camel@analog.com> (raw)
In-Reply-To: <CA+U=DsoaujpbnMGb8TB=hQoV1rnEpKwmwxcyNKVnw2Z=oCHq4Q@mail.gmail.com>
On Mon, 2019-05-20 at 11:53 +0300, Alexandru Ardelean wrote:
> [External]
>
>
> On Sun, May 19, 2019 at 12:35 AM Bárbara Fernandes
> <barbara.fernandes@usp.br> wrote:
> >
> > Create structure of type of_device_id in order to register all devices
> > the driver is able to manage.
> >
>
> Hey,
>
> CC-ing my work-email
> There are some issues with it and mailing lists; I'll hopefully sort
> them out in the next weeks.
>
> > Signed-off-by: Bárbara Fernandes <barbara.fernandes@usp.br>
> > Signed-off-by: Melissa Wen <melissa.srw@gmail.com>
> > Co-developed-by: Melissa Wen <melissa.srw@gmail.com>
> > Signed-off-by: Wilson Sales <spoonm@spoonm.org>
> > Co-developed-by: Wilson Sales <spoonm@spoonm.org>
> > ---
> > drivers/staging/iio/cdc/ad7150.c | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/drivers/staging/iio/cdc/ad7150.c
> > b/drivers/staging/iio/cdc/ad7150.c
> > index 4b1c90e1b0ea..072094227e1b 100644
> > --- a/drivers/staging/iio/cdc/ad7150.c
> > +++ b/drivers/staging/iio/cdc/ad7150.c
> > @@ -655,11 +655,21 @@ static const struct i2c_device_id ad7150_id[] = {
> > {}
> > };
> >
> > +static const struct of_device_id ad7150_of_i2c_match[] = {
> > + { .compatible = "adi,ad7150" },
> > + { .compatible = "adi,ad7151" },
> > + { .compatible = "adi,ad7156" },
> > + {}
> > +};
> > +
> > +MODULE_DEVICE_TABLE(of, ad7150_of_i2c_match);
>
> nitpick: you don't need to add i2c in the name
> so, this could be just
> MODULE_DEVICE_TABLE(of, ad7150_of_match);
>
> but it's not a blocker for this;
Actually, disregard the above comment.
I just thought of some cases where it makes sense to have the i2c in the
name. So, ad7150_of_i2c_match is fine.
>
> So,
>
> Acked-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
>
> > +
> > MODULE_DEVICE_TABLE(i2c, ad7150_id);
> >
> > static struct i2c_driver ad7150_driver = {
> > .driver = {
> > .name = "ad7150",
> > + .of_match_table = ad7150_of_i2c_match
> > },
> > .probe = ad7150_probe,
> > .id_table = ad7150_id,
> > --
> > 2.22.0.rc0.1.g337bb99195.dirty
> >
next prev parent reply other threads:[~2019-05-20 10:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-18 21:35 [PATCH 0/2] Enhance dt support and channel creation Bárbara Fernandes
2019-05-18 21:35 ` [PATCH 1/2] staging: iio: cdc: ad7150: create of_device_id array Bárbara Fernandes
2019-05-20 8:53 ` Alexandru Ardelean
2019-05-20 10:20 ` Ardelean, Alexandru [this message]
2019-05-18 21:35 ` [PATCH 2/2] staging: iio: cdc: ad7150: create macro for capacitance channels Bárbara Fernandes
2019-05-18 22:41 [RESEND PATCH 0/2] Enhance dt support and channel creation Bárbara Fernandes
2019-05-18 22:41 ` [PATCH 1/2] staging: iio: cdc: ad7150: create of_device_id array Bárbara Fernandes
2019-05-19 10:21 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28948637968846e814ac507a34c1886668d87ed7.camel@analog.com \
--to=alexandru.ardelean@analog.com \
--cc=ardeleanalex@gmail.com \
--cc=barbara.fernandes@usp.br \
--cc=linux-iio@vger.kernel.org \
--cc=melissa.srw@gmail.com \
--cc=spoonm@spoonm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.