From: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh: Update dma-sh api
Date: Mon, 02 Mar 2009 06:31:44 +0000 [thread overview]
Message-ID: <29ab51dc0903012231x158ae710q535877a12f67efca@mail.gmail.com> (raw)
In-Reply-To: <49A668C4.2020608@renesas.com>
Hi, Magnus .
2009/2/27 Magnus Damm <magnus.damm@gmail.com>:
> Hi Iwamatsu-san,
>
> On Thu, Feb 26, 2009 at 7:02 PM, Nobuhiro Iwamatsu
> <iwamatsu.nobuhiro@renesas.com> wrote:
>> Add DMA support of new SH CPU and the change of definition.
>>
>> Signed-off-by: Nobuhiro Iwamatsu <iwamatsu.nobuhiro@renesas.com>
>
> Thanks for your work on this. I have one main question and a few
> nitpicking comments on your patch.
>
> Question:
>
> Does this patch build on top of the reworked sh775x, sh7780 and sh7785
> interrupt vectors? The patchset pointed out below modifies the DMAC
> interrupt to only use a single linux interrupt instead of multiple
> with broken masking:
>
> http://patchwork.kernel.org/patch/8592/
I did not consider your patch.
I will read your patch and think.
>
>> --- /dev/null
>> +++ b/arch/sh/include/asm/dma-sh.h
>> @@ -0,0 +1,151 @@
>> +/*
>> + * arch/sh/drivers/dma/dma-sh.h
>
> Header comment mismatch. =)
>
Thanks, I will fixed next version.
Best regards,
Nobuhiro
--
Nobuhiro Iwamatsu
prev parent reply other threads:[~2009-03-02 6:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-26 10:02 [PATCH] sh: Update dma-sh api Nobuhiro Iwamatsu
2009-02-27 2:04 ` Magnus Damm
2009-03-02 6:31 ` Nobuhiro Iwamatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29ab51dc0903012231x158ae710q535877a12f67efca@mail.gmail.com \
--to=iwamatsu@nigauri.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.