From: Sagi Grimberg <sagi@grimberg.me>
To: Chaitanya Kulkarni <chaitanyak@nvidia.com>
Cc: "osandov@fb.com" <osandov@fb.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH blktests 0/3] tetss/nvme: fix nvme disc changes
Date: Thu, 13 Jan 2022 00:06:14 +0200 [thread overview]
Message-ID: <29ec2611-ad72-051d-7725-5d07fda70c04@grimberg.me> (raw)
In-Reply-To: <0dfab539-c85b-68da-0a2e-3765d7d3903e@nvidia.com>
> Sagi,
>
> On 1/12/22 12:38 AM, Sagi Grimberg wrote:
>> External email: Use caution opening links or attachments
>>
>>
>> What is preventing this to break again?
>>
>> Can we modify the tests to not rely on a consistent
>> output here. Perhaps just search/match the expected nvm subsystems
>> in the log page?
>
> Do we expect to change the output of the log page again ?
Yes, I don't expect that we will lock down the discovery output
in both the target and nvme-cli.
> It is important to match the disc subsysnqn i.e.
> "nqn.2014-08.org.nvmexpress.discovery" and gencounter,
> only matching the nvm subsystems not going to get us good
> coverage.
I'm just saying that it is not sustainable. Nothing prevents
anyone from changing the log page again.
prev parent reply other threads:[~2022-01-12 22:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-12 6:06 [PATCH blktests 0/3] tetss/nvme: fix nvme disc changes Chaitanya Kulkarni
2022-01-12 6:06 ` [PATCH blktests 1/3] tests/nvme/002: adjust to new nvme disc page output Chaitanya Kulkarni
2022-01-12 6:06 ` [PATCH blktests 2/3] tests/nvme/016: " Chaitanya Kulkarni
2022-01-12 6:06 ` [PATCH blktests 3/3] tests/nvme/017: " Chaitanya Kulkarni
2022-01-12 8:38 ` [PATCH blktests 0/3] tetss/nvme: fix nvme disc changes Sagi Grimberg
2022-01-12 17:55 ` Chaitanya Kulkarni
2022-01-12 22:06 ` Sagi Grimberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29ec2611-ad72-051d-7725-5d07fda70c04@grimberg.me \
--to=sagi@grimberg.me \
--cc=chaitanyak@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=osandov@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.