Re: [PATCH V3 3/3] scsi: core: put ->shost_gendev.parent in failure handling path

From: Hannes Reinecke <hare@suse.de>
To: Ming Lei <ming.lei@redhat.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	linux-scsi@vger.kernel.org
Cc: John Garry <john.garry@huawei.com>, Bart Van Assche <bvanassche@acm.org>
Subject: Re: [PATCH V3 3/3] scsi: core: put ->shost_gendev.parent in failure handling path
Date: Mon, 31 May 2021 08:28:49 +0200	[thread overview]
Message-ID: <2cbcfc4a-78ae-ddc9-1386-6008fcaecb0b@suse.de> (raw)
In-Reply-To: <20210531050727.2353973-4-ming.lei@redhat.com>

On 5/31/21 7:07 AM, Ming Lei wrote:
> get_device(shost->shost_gendev.parent) is called in
> scsi_add_host_with_dma(), but its counter pair isn't called in the failure
> path, so fix it by calling put_device(shost->shost_gendev.parent) in its
> failure path.
> 
> Reported-by: John Garry <john.garry@huawei.com>
> Cc: Bart Van Assche <bvanassche@acm.org>
> Cc: Hannes Reinecke <hare@suse.de>
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
> ---
>   drivers/scsi/hosts.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c
> index 6cbc3eb16525..6cc43c51b7b3 100644
> --- a/drivers/scsi/hosts.c
> +++ b/drivers/scsi/hosts.c
> @@ -298,6 +298,7 @@ int scsi_add_host_with_dma(struct Scsi_Host *shost, struct device *dev,
>    out_del_dev:
>   	device_del(&shost->shost_dev);
>    out_del_gendev:
> +	put_device(shost->shost_gendev.parent);
>   	device_del(&shost->shost_gendev);
>    out_disable_runtime_pm:
>   	device_disable_async_suspend(&shost->shost_gendev);
> 
This really needs to be folded into the first patch as it's really a 
bugfix for that.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer