From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: David Airlie <airlied@linux.ie>,
Sebastian Reichel <sebastian.reichel@collabora.com>,
Jyri Sarha <jsarha@ti.com>, Tony Lindgren <tony@atomide.com>,
dri-devel@lists.freedesktop.org,
zhong jiang <zhongjiang@huawei.com>
Subject: Re: [PATCH] omapdrm: no need to check return value of debugfs_create functions
Date: Fri, 9 Aug 2019 09:59:56 +0300 [thread overview]
Message-ID: <2d1fa29e-1441-2266-31f0-73a20cf3cebb@ti.com> (raw)
In-Reply-To: <20190808125053.GJ6055@pendragon.ideasonboard.com>
Hi,
On 08/08/2019 15:50, Laurent Pinchart wrote:
> Hi Greg,
>
> Thank you for the patch.
>
> On Thu, Jun 13, 2019 at 01:57:49PM +0200, Greg Kroah-Hartman wrote:
>> When calling debugfs functions, there is no need to ever check the
>> return value. The function can work or not, but the code logic should
>> never do something different based on this.
>>
>> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
>> Cc: David Airlie <airlied@linux.ie>
>> Cc: Daniel Vetter <daniel@ffwll.ch>
>> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>> Cc: Sebastian Reichel <sebastian.reichel@collabora.com>
>> Cc: Jyri Sarha <jsarha@ti.com>
>> Cc: Tony Lindgren <tony@atomide.com>
>> Cc: zhong jiang <zhongjiang@huawei.com>
>> Cc: dri-devel@lists.freedesktop.org
>> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> This makes sense.
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Tomi, will you take this patch in your tree ?
Yes, I'll pick this up. I presume debugfs_create_file() will give a
warning print if it fails to create the file, instead of being silent.
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-08-09 7:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 11:57 [PATCH] omapdrm: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2019-08-08 12:50 ` Laurent Pinchart
2019-08-09 6:59 ` Tomi Valkeinen [this message]
2019-08-09 7:47 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d1fa29e-1441-2266-31f0-73a20cf3cebb@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=jsarha@ti.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=sebastian.reichel@collabora.com \
--cc=tony@atomide.com \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.