Re: [PATCH 2/2] arm64: dts: renesas: Add support for M3ULCB with R-Car M3-W+

From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Yuya Hamamachi <yuya.hamamachi.sx@renesas.com>,
	linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: renesas: Add support for M3ULCB with R-Car M3-W+
Date: Mon, 9 Mar 2020 11:45:03 +0300	[thread overview]
Message-ID: <2dacb129-a429-f6df-f43c-1b4977023c0c@cogentembedded.com> (raw)
In-Reply-To: <20200309064425.25437-3-yuya.hamamachi.sx@renesas.com>

Hello!

On 09.03.2020 9:44, Yuya Hamamachi wrote:

> Add initial support for the Renesas M3ULCB board equipped with an R-Car
> M3-W+ SiP with 8 (2 x 4) GiB of RAM.
> To avoid build error on 'ulcb.dtsi', ssi2 is added into 'r8a77961.dtsi'.
> 
> Based on commit 92980759c1699a3c10beb00f411270197ac89544
> ("arm64: dts: renesas: Add support for Salvator-XS with R-Car M3-W+").
> 
> Signed-off-by: Yuya Hamamachi <yuya.hamamachi.sx@renesas.com>
[...]
> diff --git a/arch/arm64/boot/dts/renesas/r8a77961-ulcb.dts b/arch/arm64/boot/dts/renesas/r8a77961-ulcb.dts
> new file mode 100644
> index 000000000000..7db5c53dc8fc
> --- /dev/null
> +++ b/arch/arm64/boot/dts/renesas/r8a77961-ulcb.dts
> @@ -0,0 +1,31 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Device Tree Source for the M3ULCB (R-Car Starter Kit Pro) board with R-Car M3-W+
> + *
> + * Copyright (C) 2020 Renesas Electronics Corp.
> + */
> +
> +/dts-v1/;
> +#include "r8a77961.dtsi"
> +#include "ulcb.dtsi"
> +
> +/ {
> +	model = "Renesas M3ULCB board based on r8a77961";
> +	compatible = "renesas,m3ulcb", "renesas,r8a77961";
> +
> +	memory@48000000 {
> +		device_type = "memory";
> +		/* first 128MB is reserved for secure area. */
> +		reg = <0x0 0x48000000 0x0 0x78000000>;
> +	};
> +
> +	memory@400000000 {
> +		device_type = "memory";
> +		reg = <0x4 0x80000000 0x0 0x80000000>;

   The "reg" property doesn't match the <unit-address> part of the node name 
above.

[...]

MBR, Sergei