From: Guenter Roeck <linux@roeck-us.net>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
Wim Van Sebroeck <wim@linux-watchdog.org>
Subject: Re: [PATCH v1 1/3] watchdog: intel-mid_wdt: Remove unused intel-mid.h
Date: Tue, 5 Mar 2024 09:56:45 -0800 [thread overview]
Message-ID: <2e0b0f2f-3841-420e-aa17-52e3051af70a@roeck-us.net> (raw)
In-Reply-To: <20240305165306.1366823-2-andriy.shevchenko@linux.intel.com>
On Tue, Mar 05, 2024 at 06:52:18PM +0200, Andy Shevchenko wrote:
> intel-mid.h is providing some core parts of the South Complex PM,
> which are usually are not used by individual drivers. In particular,
> this driver doesn't use it, so simply remove the unused header.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/intel-mid_wdt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/watchdog/intel-mid_wdt.c b/drivers/watchdog/intel-mid_wdt.c
> index fb7fae750181..b41c45582aa4 100644
> --- a/drivers/watchdog/intel-mid_wdt.c
> +++ b/drivers/watchdog/intel-mid_wdt.c
> @@ -17,7 +17,6 @@
> #include <linux/platform_data/intel-mid_wdt.h>
>
> #include <asm/intel_scu_ipc.h>
> -#include <asm/intel-mid.h>
>
> #define IPC_WATCHDOG 0xf8
>
> --
> 2.43.0.rc1.1.gbec44491f096
>
next prev parent reply other threads:[~2024-03-05 17:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 16:52 [PATCH v1 0/3] watchdog: intel-mid_wdt: header and code cleanups Andy Shevchenko
2024-03-05 16:52 ` [PATCH v1 1/3] watchdog: intel-mid_wdt: Remove unused intel-mid.h Andy Shevchenko
2024-03-05 17:56 ` Guenter Roeck [this message]
2024-03-05 16:52 ` [PATCH v1 2/3] watchdog: intel-mid_wdt: Don't use "proxy" headers Andy Shevchenko
2024-03-05 17:57 ` Guenter Roeck
2024-03-05 16:52 ` [PATCH v1 3/3] watchdog: intel-mid_wdt: Get platform data via dev_get_platdata() Andy Shevchenko
2024-03-05 17:57 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e0b0f2f-3841-420e-aa17-52e3051af70a@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.