Re: [PATCH] configure: ignore --make

From: Paolo Bonzini <pbonzini@redhat.com>
To: Matheus Kowalczuk Ferst <matheus.ferst@eldorado.org.br>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [PATCH] configure: ignore --make
Date: Wed, 8 Jun 2022 17:54:46 +0200	[thread overview]
Message-ID: <2f19b91a-e641-9d20-0158-c7bb71693ad5@redhat.com> (raw)
In-Reply-To: <75ed39ec-ed5c-a9b6-c51e-94e26a333316@eldorado.org.br>

On 6/8/22 16:21, Matheus Kowalczuk Ferst wrote:
> On a clean build on FreeBSD with this patch, I got:
> 
> ../meson.build:3641:0: ERROR: Key MAKE is not in dict
> 
> So it seems that we need to remove the use of MAKE in meson.build too.

Oops, yes.  That's the typical "forget git commit --amend before sending 
out" mistake for me.

> Also, we will not have this error at configure-time anymore, but I 
> suppose that *BSD users will identify the problem if they try to build 
> with non-gnu make.

Yeah, my guess was that "try ./configure && make" with GNU Make 
installed is the more common failure mode, since QEMU is certainly not 
the only package that requires GNU Make.

Alternatively, I can leave in the check for GNU Make, or move it to 
meson as a "now type "make" to build QEMU" kind of message, and still 
remove the unused --make option.

Paolo