From: David Hildenbrand <david@redhat.com>
To: Vlastimil Babka <vbabka@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Alexander Potapenko <glider@google.com>,
Kees Cook <keescook@chromium.org>,
Michal Hocko <mhocko@kernel.org>,
Mateusz Nosek <mateusznosek0@gmail.com>,
Laura Abbott <labbott@kernel.org>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>
Subject: Re: [PATCH v3 3/5] kernel/power: allow hibernation with page_poison sanity checking
Date: Fri, 13 Nov 2020 13:17:16 +0100 [thread overview]
Message-ID: <3028d955-5cc7-aa52-5c07-7109038fdd3e@redhat.com> (raw)
In-Reply-To: <c15ceaa4-c211-d95e-fb6c-3cb6c93b6549@suse.cz>
On 13.11.20 13:15, Vlastimil Babka wrote:
> On 11/13/20 1:10 PM, David Hildenbrand wrote:
>>> @@ -1186,12 +1194,12 @@ void clear_free_pages(void)
>>> if (WARN_ON(!(free_pages_map)))
>>> return;
>>>
>>> - if (IS_ENABLED(CONFIG_PAGE_POISONING_ZERO) || want_init_on_free()) {
>>> + if (page_poisoning_enabled() || want_init_on_free()) {
>>
>> Any reason why not to use the static version here?
>
> It's a single check per resume, so not worth live-patching this place.
Agreed, thanks.
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2020-11-13 12:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 10:40 [PATCH v3 0/5] cleanup page poisoning Vlastimil Babka
2020-11-13 10:40 ` [PATCH v3 1/5] mm, page_alloc: do not rely on the order of page_poison and init_on_alloc/free parameters Vlastimil Babka
2020-11-13 10:40 ` [PATCH v3 2/5] mm, page_poison: use static key more efficiently Vlastimil Babka
2020-11-13 12:08 ` David Hildenbrand
2020-11-13 10:40 ` [PATCH v3 3/5] kernel/power: allow hibernation with page_poison sanity checking Vlastimil Babka
2020-11-13 12:10 ` David Hildenbrand
2020-11-13 12:15 ` Vlastimil Babka
2020-11-13 12:17 ` David Hildenbrand [this message]
2020-11-13 10:40 ` [PATCH v3 4/5] mm, page_poison: remove CONFIG_PAGE_POISONING_NO_SANITY Vlastimil Babka
2020-11-13 10:40 ` [PATCH v3 5/5] mm, page_poison: remove CONFIG_PAGE_POISONING_ZERO Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3028d955-5cc7-aa52-5c07-7109038fdd3e@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=glider@google.com \
--cc=keescook@chromium.org \
--cc=labbott@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mateusznosek0@gmail.com \
--cc=mhocko@kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.