Re: [kvm-unit-tests PATCH 2/2] x86: Create ISO images according to unittests.cfg

From: Nadav Amit <nadav.amit@gmail.com>
To: Yi Sun <yi.sun@intel.com>
Cc: kvm@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH 2/2] x86: Create ISO images according to unittests.cfg
Date: Thu, 3 Jun 2021 20:06:07 -0700	[thread overview]
Message-ID: <30FA4AAE-DBC9-4DB7-8742-079F2B3067C3@gmail.com> (raw)
In-Reply-To: <20210604023453.905512-2-yi.sun@intel.com>

> On Jun 3, 2021, at 7:34 PM, Yi Sun <yi.sun@intel.com> wrote:
> 
> Create ISO image according to the configure file unittests.cfg,
> where describes the parameters of each test case.
> 

Looks cool!

> diff --git a/x86/create_iso.sh b/x86/create_iso.sh
> new file mode 100755
> index 0000000..8486be7
> --- /dev/null
> +++ b/x86/create_iso.sh
> @@ -0,0 +1,71 @@
> +#!/bin/bash
> +set -e
> +config_file=$1
> +
> +opts=
> +extra_params=
> +kernel=
> +smp=
> +testname=
> +
> +
> +grub_cfg() {
> +
> +	kernel_elf=$1
> +	kernel_para=$2
> +
> +	cat << EOF
> +set timeout=0
> +set default=0
> +
> +
> +menuentry "${kernel_elf}" {
> +    multiboot /boot/${kernel_elf} ${kernel_para}

Any chance you can add an optional “module” command here, that
would be configurable as a parameter to create_iso.sh?

I use such a command to provide parameters that kvm-unit-tests
usually gets from the “firmware" (and therefore are not available
in certain environments). 

The “module” can look something like:
	NR_CPUS=56
	MEMSIZE=4096
	TEST_DEVICE=0
	BOOTLOADER=1 

(kvm-unit-tests already knows to use these values)

This “module" would need to be copied into build/isofiles/boot as
well.