From: Matthieu Baerts <matthieu.baerts@tessares.net>
To: mptcp@lists.linux.dev, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Shuah Khan <shuah@kernel.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next 3/4] mptcp: do not fill info not used by the PM in used
Date: Fri, 24 Mar 2023 19:58:16 +0100 [thread overview]
Message-ID: <3100c8b2-4576-03eb-52a5-10d6ddf0fedc@tessares.net> (raw)
In-Reply-To: <20230324-upstream-net-next-20230324-misc-features-v1-3-5a29154592bd@tessares.net>
Hello,
On 24/03/2023 18:11, Matthieu Baerts wrote:
> Only the in-kernel PM uses the number of address and subflow limits
> allowed per connection.
>
> It then makes more sense not to display such info when other PMs are
> used not to confuse the userspace by showing limits not being used.
>
> While at it, we can get rid of the "val" variable and add indentations
> instead.
>
> It would have been good to have done this modification directly in
> commit 3fd4c2a2d672 ("mptcp: bypass in-kernel PM restrictions for non-kernel PMs")
I'm sorry, I just noticed I picked the wrong SHA for this commit and my
scripts only checked the ones mentioned in the "Fixes" tags. We should
have this instead:
> commit 4d25247d3ae4 ("mptcp: bypass in-kernel PM restrictions for non-kernel PMs")
I can send a v2 later to fix the SHA if there is no other comments.
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
next prev parent reply other threads:[~2023-03-24 18:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 17:11 [PATCH net-next 0/4] mptcp: a couple of cleanups and improvements Matthieu Baerts
2023-03-24 17:11 ` [PATCH net-next 1/4] mptcp: avoid unneeded address copy Matthieu Baerts
2023-03-24 17:11 ` [PATCH net-next 2/4] mptcp: simplify subflow_syn_recv_sock() Matthieu Baerts
2023-03-24 17:11 ` [PATCH net-next 3/4] mptcp: do not fill info not used by the PM in used Matthieu Baerts
2023-03-24 18:58 ` Matthieu Baerts [this message]
2023-03-24 17:11 ` [PATCH net-next 4/4] selftests: mptcp: add mptcp_info tests Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3100c8b2-4576-03eb-52a5-10d6ddf0fedc@tessares.net \
--to=matthieu.baerts@tessares.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.