From: Julien Grall <julien@xen.org>
To: Michal Orzel <michal.orzel@amd.com>,
Shawn Anastasio <sanastasio@raptorengineering.com>,
xen-devel@lists.xenproject.org
Cc: Timothy Pearson <tpearson@raptorengineering.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Bertrand Marquis <bertrand.marquis@arm.com>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v2] xen/arm: bootfdt: Harden handling of malformed mem reserve map
Date: Fri, 12 Jan 2024 11:05:32 +0000 [thread overview]
Message-ID: <31997e9d-35f7-4916-b6d7-de38b2697ef7@xen.org> (raw)
In-Reply-To: <62bb1962-6668-4243-b41d-5aca5d3b7ecd@amd.com>
Hi,
On 12/01/2024 08:56, Michal Orzel wrote:
>
>
> On 12/01/2024 00:24, Shawn Anastasio wrote:
>>
>>
>> The early_print_info routine in bootfdt.c incorrectly stores the result
>> of a call to fdt_num_mem_rsv() in an unsigned int, which results in the
>> negative error code being interpreted incorrectly in a subsequent loop
>> in the case where the device tree is malformed. Fix this by properly
>> checking the return code for an error and calling panic().
>>
>> Signed-off-by: Shawn Anastasio <sanastasio@raptorengineering.com>
> Reviewed-by: Michal Orzel <michal.orzel@amd.com>
Committed.
Cheers,
--
Julien Grall
prev parent reply other threads:[~2024-01-12 11:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 23:24 [PATCH v2] xen/arm: bootfdt: Harden handling of malformed mem reserve map Shawn Anastasio
2024-01-12 8:56 ` Michal Orzel
2024-01-12 11:05 ` Julien Grall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31997e9d-35f7-4916-b6d7-de38b2697ef7@xen.org \
--to=julien@xen.org \
--cc=Volodymyr_Babchuk@epam.com \
--cc=bertrand.marquis@arm.com \
--cc=michal.orzel@amd.com \
--cc=sanastasio@raptorengineering.com \
--cc=sstabellini@kernel.org \
--cc=tpearson@raptorengineering.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.