From: Michael Krause <mk-linuxwireless@galax.is>
To: johannes@sipsolutions.net
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC PATCH] wifi: cfg80211: fix CQM for non-range use
Date: Tue, 28 Nov 2023 18:47:42 +0100 [thread overview]
Message-ID: <31cd6c6a-7c0d-4fe3-832d-603afe0125e9@galax.is> (raw)
In-Reply-To: <20231106231715.3a506ac2dadb.Ie774b85b9d4ff934a1236e77096cb9c6c9fe6561@changeid>
Dear Johannes,
You are probably aware of this already, but I believe this patch is quite crucial as your earlier patch may have effectively broken some roaming scenarios using wpa_supplicant.
The supplicant is using CQM to monitor for RSSI threshold changes (non-ranged) to switch between short (few seconds) and very long (1 *hour* in the default NetworkManager setting) background scan intervals. With a current lts kernel (6.1.63) on Arch I do not see RSSI change events at all and wpa_supplicant will almost never (1 hour timeout) scan for a better AP as long as the current AP is still in range.
I applied your patch against 6.1.63 with some additional `goto unlock`s and it resolves the issue for me. I've been running the kernel for 2 days now.
cheers,
Michael
prev parent reply other threads:[~2023-11-28 19:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-06 22:17 [RFC PATCH] wifi: cfg80211: fix CQM for non-range use Johannes Berg
2023-11-09 0:02 ` kernel test robot
2023-11-28 14:44 ` Michael Walle
2023-11-28 18:23 ` Johannes Berg
2023-11-28 21:01 ` Jeff Johnson
2023-11-30 18:32 ` Kees Cook
2023-11-30 18:40 ` Johannes Berg
2023-11-30 18:46 ` Kees Cook
2023-11-30 18:52 ` Johannes Berg
2023-11-30 18:52 ` Kees Cook
2023-11-30 18:54 ` Johannes Berg
2023-11-30 18:55 ` Kees Cook
2023-11-30 19:00 ` Johannes Berg
2023-11-28 17:47 ` Michael Krause [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31cd6c6a-7c0d-4fe3-832d-603afe0125e9@galax.is \
--to=mk-linuxwireless@galax.is \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.