From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Michal Simek <michal.simek@amd.com>,
linux-kernel@vger.kernel.org, monstr@monstr.eu,
michal.simek@xilinx.com, git@xilinx.com
Cc: Conor Dooley <conor+dt@kernel.org>,
Guenter Roeck <linux@roeck-us.net>,
Jean Delvare <jdelvare@suse.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: hwmon: ina2xx: Add label property
Date: Thu, 21 Dec 2023 13:11:40 +0100 [thread overview]
Message-ID: <3268b95b-dc1d-4711-a81b-42f39ca40f9c@linaro.org> (raw)
In-Reply-To: <9bfb12c8-2a38-407c-b9fb-22888c5bb8b9@amd.com>
On 21/12/2023 12:24, Michal Simek wrote:
>
>
> On 12/21/23 10:06, Krzysztof Kozlowski wrote:
>> On 20/12/2023 14:12, Michal Simek wrote:
>>> Add a label property to allow a custom name to be used for identifying
>>> a device on the board. This is useful when multiple devices are present on
>>> the same board. Similar change was done by commit ffae65fb1ae4
>>> ("dt-bindings: spi: spi-cadence: Add label property").
>>>
>>> Signed-off-by: Michal Simek <michal.simek@amd.com>
>>> ---
>>>
>>> zcu102 is using this feature
>>
>> Is the driver or driver core parsing it?
>
> I see that functions to be in hwmon and iio cores.
>
> drivers/hwmon/hwmon.c:820: err = device_property_read_string(dev, "label",
> &label);
>
> drivers/iio/industrialio-core.c:1914: fwnode_property_read_string(fwnode,
> "label", &indio_dev->label);
I wonder why it is not in bindings/iio/common.yaml...
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-12-21 12:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 13:12 [PATCH 1/2] dt-bindings: hwmon: ina2xx: Add label property Michal Simek
2023-12-20 13:12 ` [PATCH 2/2] dt-bindings: hwmon: ina2xx: Describe #io-channel-cells property Michal Simek
2023-12-21 9:06 ` Krzysztof Kozlowski
2024-01-17 21:23 ` Guenter Roeck
2023-12-21 9:06 ` [PATCH 1/2] dt-bindings: hwmon: ina2xx: Add label property Krzysztof Kozlowski
2023-12-21 11:24 ` Michal Simek
2023-12-21 12:11 ` Krzysztof Kozlowski [this message]
2023-12-21 12:11 ` Krzysztof Kozlowski
2024-01-17 21:22 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3268b95b-dc1d-4711-a81b-42f39ca40f9c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=git@xilinx.com \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=michal.simek@amd.com \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.