From: Sundar R IYER <sundar.iyer@stericsson.com>
To: "Datta, Shubhrajyoti" <shubhrajyoti@ti.com>,
"ken.lierman@windriver.com" <ken.lierman@windriver.com>
Cc: "dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
"alan@linux.intel.com" <alan@linux.intel.com>,
Linus WALLEIJ <linus.walleij@stericsson.com>,
Rabin VINCENT <rabin.vincent@stericsson.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
Subject: RE: [PATCH] input/tc3589x: add support for tc3589x driver
Date: Mon, 29 Nov 2010 07:39:48 +0100 [thread overview]
Message-ID: <33A307AF30D7BF4F811B1568FE7A9B1804713A939C@EXDCVYMBSTM006.EQ1STM.local> (raw)
In-Reply-To: <0680EC522D0CC943BC586913CF3768C004137FE6A8@dbde02.ent.ti.com>
Hi Shubhra/Dmitry,
Thanx for your comments.
>-----Original Message-----
>From: Datta, Shubhrajyoti [mailto:shubhrajyoti@ti.com]
>
>Be careful about the permissions.
>
>This need not be __devinit as the sysfs hooks may need it.
>
>Could you use tabs instead of spaces here.
>-----Original Message-----
>From: Dmitry Torokhov [mailto:dmitry.torokhov@gmail.com]
>
>The driver looks very reasonably with the exception of enable/disable
>sysfs attribute and its handling. As I mentioned in few other threads we
>can't keep adding custom PM methods to the drivers; instead we need to
>move this functionality into PM/driver core and allow userspace
>accelerate putting devices into low power state.
>
>BTW, I think spotted a few instances of space vs tab indentation and a
>few pointless casts from (void *).
As I mentioned, this is not the final patch. This patch is for Ken to try to work
out the TC35894 keypad in this MFD plugged-in driver. I don't have access to the
TC35894 data sheet; but going through the register definitions in the patch posted
by Alan, I don't see any register changes and the same driver *should* just work out fine.
Anyways I will re-post this series updated with your and Dmitry's comments. I also need to
push out the TC35892 MFD driver updated to the MFD maintainer also.
Cheers!
prev parent reply other threads:[~2010-11-29 6:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-26 15:05 [PATCH] input/tc3589x: add support for tc3589x driver Sundar Iyer
2010-11-26 15:11 ` Sundar R IYER
2010-11-27 8:26 ` Dmitry Torokhov
2010-11-29 6:30 ` Datta, Shubhrajyoti
2010-11-29 6:39 ` Sundar R IYER [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33A307AF30D7BF4F811B1568FE7A9B1804713A939C@EXDCVYMBSTM006.EQ1STM.local \
--to=sundar.iyer@stericsson.com \
--cc=alan@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=ken.lierman@windriver.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-input@vger.kernel.org \
--cc=rabin.vincent@stericsson.com \
--cc=shubhrajyoti@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.