From: Jerry Snitselaar <jsnitsel@redhat.com>
To: "Yu, Fenghua" <fenghua.yu@intel.com>,
"Jiang, Dave" <dave.jiang@intel.com>,
"Zhu, Tony" <tony.zhu@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Vinod Koul <vkoul@kernel.org>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>
Subject: Re: [PATCH v2] dmaengine: idxd: avoid deadlock in process_misc_interrupts()
Date: Wed, 24 Aug 2022 14:34:00 -0700 [thread overview]
Message-ID: <33a546ea17fe62ca9fc763041fe340ad5e4945fe.camel@redhat.com> (raw)
In-Reply-To: <IA1PR11MB6097988CC9C2C1C713E3D8339B739@IA1PR11MB6097.namprd11.prod.outlook.com>
On Wed, 2022-08-24 at 21:11 +0000, Yu, Fenghua wrote:
> Hi, Jerry,
>
> > I see another potential issue. If a software reset is attempted
> > idxd_device_reinit()
> > will be called which walks the wqs, and if a wq has the state
> > IDXD_WQ_ENABLED it calls idxd_wq_enable(), but the first thing
> > idxd_wq_enable() does is see that the state is IDXD_WQ_ENABLED and
> > returns 0.
> > Without the wq enable command being sent, it will not be re-
> > enabled, yes?
>
> Could you please describe how to reproduce the issues and test case?
Nothing special, just running dsa_user_test_runner.sh from idxd-config
(3.4.6.3) with intel_iommu=on,sm_on (default is lazy dma domain) on an
Intel supplied SPR system. During the run there is a dmar fault, halts
the device with it needing an flr reset. That is where the deadlock was
noticed. Then after the dsa_user_runner.sh fails, if you do modprobe -r
idxd, you hit the warning in devm_iounmap().
The idxd_device_reinit() case I haven't reproduced, I'm just looking at
the code.
I should note that I've only run into an issue with that model
of system. The other models of SPR systems don't hit an issue. This is
with a 6.0-rc1 kernel, and our kernel. I'm guessing there is an issue
with that model of system/fw. I've seen both fault reasons 0x50 and
0x58 when it faults.
Regards,
Jerry
>
> Thanks.
>
> -Fenghua
next prev parent reply other threads:[~2022-08-24 21:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 16:24 [PATCH] idxd: avoid deadlock in process_misc_interrupts() Jerry Snitselaar
2022-08-23 16:37 ` [PATCH v2] dmaengine: " Jerry Snitselaar
2022-08-23 16:46 ` Dave Jiang
2022-08-24 0:54 ` Jerry Snitselaar
2022-08-24 17:45 ` Dave Jiang
2022-08-24 18:42 ` Jerry Snitselaar
2022-08-24 21:11 ` Yu, Fenghua
2022-08-24 21:34 ` Jerry Snitselaar [this message]
2022-09-04 16:28 ` Vinod Koul
2022-12-12 18:47 ` [PATCH] " Yu, Fenghua
2022-12-12 20:08 ` Jerry Snitselaar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33a546ea17fe62ca9fc763041fe340ad5e4945fe.camel@redhat.com \
--to=jsnitsel@redhat.com \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=fenghua.yu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.zhu@intel.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.