From: Subhash Jadavani <subhashj@codeaurora.org>
To: Asutosh Das <asutoshd@codeaurora.org>
Cc: cang@codeaurora.org, vivek.gautam@codeaurora.org,
rnayak@codeaurora.org, vinholikatti@gmail.com,
jejb@linux.vnet.ibm.com, martin.petersen@oracle.com,
linux-mmc@vger.kernel.org, linux-scsi@vger.kernel.org,
Yaniv Gardi <ygardi@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 01/10] scsi: ufs: Allowing power mode change
Date: Wed, 16 May 2018 14:09:51 -0700 [thread overview]
Message-ID: <33a5e196be45bfeb0bea49a446e8af98@codeaurora.org> (raw)
In-Reply-To: <75e5ea5901004ef95b37aed719686214910f6541.1525343531.git.asutoshd@codeaurora.org>
On 2018-05-03 04:07, Asutosh Das wrote:
> From: Yaniv Gardi <ygardi@codeaurora.org>
>
> Due to M-PHY issues, moving from HS to any other mode or gear or
> even Hibern8 may cause some un-predicted behavior
> of the device.
> This patch adds provides a quirk to address that.
>
> Signed-off-by: Yaniv Gardi <ygardi@codeaurora.org>
> Signed-off-by: Subhash Jadavani <subhashj@codeaurora.org>
> Signed-off-by: Can Guo <cang@codeaurora.org>
> Signed-off-by: Asutosh Das <asutoshd@codeaurora.org>
> ---
> drivers/scsi/ufs/ufshcd.c | 8 +++++++-
> drivers/scsi/ufs/ufshcd.h | 7 +++++++
> 2 files changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 5bc9dc1..f3083fe 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -4162,9 +4162,15 @@ static int ufshcd_link_startup(struct ufs_hba
> *hba)
> goto out;
> } while (ret && retries--);
>
> - if (ret)
> + if (ret) {
> /* failed to get the link up... retire */
> goto out;
> + }
> +
> + if (hba->quirks & UFSHCD_QUIRK_BROKEN_PWR_MODE_CHANGE) {
> + ufshcd_dme_set(hba, UIC_ARG_MIB(TX_LCC_ENABLE), 0);
> + ufshcd_dme_set(hba, UIC_ARG_MIB(TX_LCC_ENABLE), 1);
> + }
>
> if (link_startup_again) {
> link_startup_again = false;
> diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
> index cbe46f6..bb4ecfb 100644
> --- a/drivers/scsi/ufs/ufshcd.h
> +++ b/drivers/scsi/ufs/ufshcd.h
> @@ -591,6 +591,13 @@ struct ufs_hba {
> */
> #define UFSHCD_QUIRK_PRDT_BYTE_GRAN UFS_BIT(7)
>
> + /*
> + * Needs to be enabled if moving from HS to any other gear/mode or
> even
> + * hibern8 causes unpredicted behavior of device.
> + * If this quirk is enabled, standard UFS driver will disable/enable
> + * TX_LCC.
> + */
> + #define UFSHCD_QUIRK_BROKEN_PWR_MODE_CHANGE UFS_BIT(8)
> unsigned int quirks; /* Deviations from standard UFSHCI spec. */
>
> /* Device deviations from standard UFS device spec. */
This was probably needed in early generation of UFS devices (non
commercial) and may not be really needed now. I believe we can skip this
patch.
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2018-05-16 21:09 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1525341340.git.asutoshd@codeaurora.org>
[not found] ` <cover.1525343531.git.asutoshd@codeaurora.org>
2018-05-03 11:07 ` [PATCH v2 01/10] scsi: ufs: Allowing power mode change Asutosh Das
2018-05-03 11:07 ` Asutosh Das
2018-05-16 21:09 ` Subhash Jadavani [this message]
2018-05-03 11:07 ` [PATCH v2 02/10] scsi: ufs-qcom: Enable UFSHCD_QUIRK_BROKEN_PWR_MODE_CHANGE quirk Asutosh Das
2018-05-03 11:07 ` Asutosh Das
2018-05-16 21:10 ` Subhash Jadavani
2018-05-03 11:07 ` [PATCH v2 03/10] scsi: ufs: Add LCC quirk for host and device Asutosh Das
2018-05-03 11:07 ` Asutosh Das
2018-05-16 21:11 ` Subhash Jadavani
2018-05-03 11:07 ` [PATCH v2 04/10] scsi: ufs: fix exception event handling Asutosh Das
2018-05-03 11:07 ` Asutosh Das
2018-05-16 21:12 ` Subhash Jadavani
2018-05-03 11:07 ` [PATCH v2 05/10] scsi: ufshcd: fix possible unclocked register access Asutosh Das
2018-05-03 11:07 ` Asutosh Das
2018-05-16 21:12 ` Subhash Jadavani
2018-05-03 11:07 ` [PATCH v2 06/10] scsi: ufs: add reference counting for scsi block requests Asutosh Das
2018-05-03 11:07 ` Asutosh Das
2018-05-16 21:13 ` Subhash Jadavani
2018-05-03 11:07 ` [PATCH v2 07/10] scsi: ufs-qcom: remove broken hci version quirk Asutosh Das
2018-05-03 11:07 ` Asutosh Das
2018-05-16 21:13 ` Subhash Jadavani
2018-05-03 11:07 ` [PATCH v2 08/10] scsi: ufs: make sure all interrupts are processed Asutosh Das
2018-05-03 11:07 ` Asutosh Das
2018-05-16 21:14 ` Subhash Jadavani
2018-05-03 11:07 ` [PATCH v2 09/10] scsi: ufs: fix irq return code Asutosh Das
2018-05-03 11:07 ` Asutosh Das
2018-06-28 22:26 ` Subhash Jadavani
2018-05-03 11:07 ` [PATCH v2 10/10] scsi: ufs: Add clock ungating to a separate workqueue Asutosh Das
2018-05-03 11:07 ` Asutosh Das
2018-05-16 21:14 ` Subhash Jadavani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33a5e196be45bfeb0bea49a446e8af98@codeaurora.org \
--to=subhashj@codeaurora.org \
--cc=asutoshd@codeaurora.org \
--cc=cang@codeaurora.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=rnayak@codeaurora.org \
--cc=vinholikatti@gmail.com \
--cc=vivek.gautam@codeaurora.org \
--cc=ygardi@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.