From: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
To: Marijn Suijten <marijn.suijten@somainline.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
robdclark@gmail.com, sean@poorly.run, airlied@linux.ie,
daniel@ffwll.ch, abhinavk@codeaurora.org,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org,
konrad.dybcio@somainline.org, martin.botka@somainline.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, paul.bouchara@somainline.org
Subject: Re: [PATCH v2 2/2] drm/msm/dpu: Fix timeout issues on command mode panels
Date: Wed, 22 Dec 2021 12:28:52 +0100 [thread overview]
Message-ID: <33d44631-f0d7-83cc-569d-d6d6f82d6808@somainline.org> (raw)
In-Reply-To: <20211211215718.pe675o5wvculxavc@SoMainline.org>
Il 11/12/21 22:57, Marijn Suijten ha scritto:
> On 2021-12-12 00:49:09, Dmitry Baryshkov wrote:
>> On Sun, 12 Dec 2021 at 00:35, Marijn Suijten
>> <marijn.suijten@somainline.org> wrote:
>>> [..]
>>> On this note, does it perhaps make more sense to call the "internal"
>>> _dpu_encoder_phys_cmd_wait_for_idle function directly, instead of going
>>> through the "public" dpu_encoder_phys_cmd_wait_for_tx_complete which
>>> seems solely intended to handle the wait_for_tx_complete callback?
>>
>> Either one would work. The main difference is the error message. Do
>> you want to see it here if the wait times out or not?
>
> I prefer calling _dpu_encoder_phys_cmd_wait_for_idle directly and
> optionally adding our own error message. IIRC DRM_ERROR prints source
> information such as the function this originated from, and that makes it
> impossible to distinguish between the wait_for_tx_complete callback or
> the invocation through dpu_encoder_phys_cmd_wait_for_commit_done anyway.
>
> - Marijn
>
I wouldn't be happy to find myself in a situation in which I get strange
display slowness without any print to help me; for this reason, I find
having the print in place useful for debugging of both perf and fault.
Cheers,
- Angelo
next prev parent reply other threads:[~2021-12-22 11:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-11 16:39 [PATCH v2 1/2] drm/msm/dpu: Add a function to retrieve the current CTL status AngeloGioacchino Del Regno
2021-09-11 16:39 ` AngeloGioacchino Del Regno
2021-09-11 16:39 ` [PATCH v2 2/2] drm/msm/dpu: Fix timeout issues on command mode panels AngeloGioacchino Del Regno
2021-09-11 16:39 ` AngeloGioacchino Del Regno
2021-09-13 14:14 ` Marijn Suijten
2021-09-13 14:14 ` Marijn Suijten
2021-10-01 22:33 ` Dmitry Baryshkov
2021-10-01 22:33 ` Dmitry Baryshkov
2021-12-09 17:02 ` AngeloGioacchino Del Regno
2021-12-09 17:02 ` AngeloGioacchino Del Regno
2021-12-11 21:35 ` Marijn Suijten
2021-12-11 21:35 ` Marijn Suijten
2021-12-11 21:49 ` Dmitry Baryshkov
2021-12-11 21:57 ` Marijn Suijten
2021-12-11 21:57 ` Marijn Suijten
2021-12-22 11:28 ` AngeloGioacchino Del Regno [this message]
2021-12-22 11:54 ` Marijn Suijten
2021-12-22 11:54 ` Marijn Suijten
2022-02-18 17:26 ` Dmitry Baryshkov
2022-02-18 17:26 ` Dmitry Baryshkov
2022-02-18 19:27 ` [PATCH v2 1/2] drm/msm/dpu: Add a function to retrieve the current CTL status Dmitry Baryshkov
2022-02-18 19:27 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33d44631-f0d7-83cc-569d-d6d6f82d6808@somainline.org \
--to=angelogioacchino.delregno@somainline.org \
--cc=abhinavk@codeaurora.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=paul.bouchara@somainline.org \
--cc=phone-devel@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.