From: Guenter Roeck <linux@roeck-us.net>
To: Konstantin Aladyshev <aladyshev22@gmail.com>
Cc: Jean Delvare <jdelvare@suse.com>,
Naresh Solanki <Naresh.Solanki@9elements.com>,
Patrick Rudolph <patrick.rudolph@9elements.com>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] hwmon: (pmbus/mp2975) Fix driver initialization for MP2975 device
Date: Sat, 27 Jan 2024 07:22:56 -0800 [thread overview]
Message-ID: <33da3135-4450-4c5e-92af-0d361c3b7489@roeck-us.net> (raw)
In-Reply-To: <20240127092516.1641-1-aladyshev22@gmail.com>
On 1/27/24 01:25, Konstantin Aladyshev wrote:
> The commit 1feb31e810b0 ("hwmon: (pmbus/mp2975) Simplify VOUT code")
> has introduced a bug that makes it impossible to initialize MP2975
> device:
> """
> mp2975 5-0020: Failed to identify chip capabilities
> i2c i2c-5: new_device: Instantiated device mp2975 at 0x20
> i2c i2c-5: delete_device: Deleting device mp2975 at 0x20
> """
> Since the 'read_byte_data' function was removed from the
> 'pmbus_driver_info ' structure the driver no longer reports correctly
> that VOUT mode is direct. Therefore 'pmbus_identify_common' fails
> with error, making it impossible to initialize the device.
>
> Restore 'read_byte_data' function to fix the issue.
>
> Tested:
> - before: it is not possible to initialize MP2975 device with the
> 'mp2975' driver,
> - after: 'mp2975' correctly initializes MP2975 device and all sensor
> data is correct.
>
> Fixes: 1feb31e810b0 ("hwmon: (pmbus/mp2975) Simplify VOUT code")
>
> Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
> ---
> Changes in v4:
> - Correct comment inside the 'mp2975_read_byte_data' function as
> suggested by Patrick Rudolph
>
I already applied version 3 of the patch. Feel free to send a follow-up
to that patch. It is too late for a v4 of the original patch.
Guenter
prev parent reply other threads:[~2024-01-27 15:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-27 9:25 [PATCH v4] hwmon: (pmbus/mp2975) Fix driver initialization for MP2975 device Konstantin Aladyshev
2024-01-27 15:22 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33da3135-4450-4c5e-92af-0d361c3b7489@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Naresh.Solanki@9elements.com \
--cc=aladyshev22@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrick.rudolph@9elements.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.