From: Christian Hewitt <christianshewitt@gmail.com>
To: Sean Young <sean@mess.org>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] media: rc: add keymap for Beelink Mini MXIII remote
Date: Tue, 31 Jan 2023 17:00:59 +0400 [thread overview]
Message-ID: <34CD7297-AC0A-404D-B90C-D00FA861A43E@gmail.com> (raw)
In-Reply-To: <Y9kJfPqtd98wIQ6r@gofer.mess.org>
> On 31 Jan 2023, at 4:28 pm, Sean Young <sean@mess.org> wrote:
>
> On Mon, Jan 30, 2023 at 03:30:20PM -0600, Rob Herring wrote:
>> On Sun, Jan 29, 2023 at 08:38:06AM +0000, Sean Young wrote:
>>> On Sat, Jan 28, 2023 at 11:11:32AM +0100, Krzysztof Kozlowski wrote:
>>>> On 28/01/2023 04:41, Christian Hewitt wrote:
>>>>> Add a keymap and bindings for the simple IR (NEC) remote used with
>>>>> the Beelink Mini MXIII Android STB device.
>>>>>
>>>>> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
>>>>> ---
>>>>> .../devicetree/bindings/media/rc.yaml | 1 +
>>>>> drivers/media/rc/keymaps/Makefile | 1 +
>>>>> drivers/media/rc/keymaps/rc-beelink-mxiii.c | 54 +++++++++++++++++++
>>>>> include/media/rc-map.h | 1 +
>>>>> 4 files changed, 57 insertions(+)
>>>>> create mode 100644 drivers/media/rc/keymaps/rc-beelink-mxiii.c
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/media/rc.yaml b/Documentation/devicetree/bindings/media/rc.yaml
>>>>> index 266f1d5cae51..f390a5d2c82d 100644
>>>>> --- a/Documentation/devicetree/bindings/media/rc.yaml
>>>>> +++ b/Documentation/devicetree/bindings/media/rc.yaml
>>>>> @@ -39,6 +39,7 @@ properties:
>>>>> - rc-avertv-303
>>>>> - rc-azurewave-ad-tu700
>>>>> - rc-beelink-gs1
>>>>> + - rc-beelink-mxiii
>>>>
>>>> Bindings are separate patches. Didn't you get such feedback already?
>>>
>>> The only change for new keymaps is an added entry to the rc-map-name enum.
>>> In the past, new keymaps have been accepted with that single line in the
>>> same commit.
>>
>> It's been a checkpatch.pl warning since 2018. The separation is so that
>> commit messages in the DT only repo[1] make sense.
>
> Ok, makes sense.
I will resend v2 series(s) with the bindings separated. Are there any other
issues to address?
Christian
next prev parent reply other threads:[~2023-01-31 13:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-28 3:41 [PATCH] media: rc: add keymap for Beelink Mini MXIII remote Christian Hewitt
2023-01-28 10:11 ` Krzysztof Kozlowski
2023-01-28 15:22 ` Christian Hewitt
2023-01-29 8:38 ` Sean Young
2023-01-30 21:30 ` Rob Herring
2023-01-31 12:28 ` Sean Young
2023-01-31 13:00 ` Christian Hewitt [this message]
2023-01-31 14:09 ` Sean Young
2023-01-31 14:11 ` Christian Hewitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34CD7297-AC0A-404D-B90C-D00FA861A43E@gmail.com \
--to=christianshewitt@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=sean@mess.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.