Re: [PATCHv2 bpf-next 0/8] bpf: Add cookies retrieval for perf/kprobe multi links

From: Quentin Monnet <quentin@isovalent.com>
To: Jiri Olsa <jolsa@kernel.org>, Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Andrii Nakryiko <andrii@kernel.org>
Cc: bpf@vger.kernel.org, Martin KaFai Lau <kafai@fb.com>,
	Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
	John Fastabend <john.fastabend@gmail.com>,
	KP Singh <kpsingh@chromium.org>,
	Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
	Yafang Shao <laoar.shao@gmail.com>
Subject: Re: [PATCHv2 bpf-next 0/8] bpf: Add cookies retrieval for perf/kprobe multi links
Date: Fri, 19 Jan 2024 13:01:30 +0000	[thread overview]
Message-ID: <358262f0-6047-4a2a-b9b2-bcf7b250112c@isovalent.com> (raw)
In-Reply-To: <20240119110505.400573-1-jolsa@kernel.org>

2024-01-19 11:05 UTC+0000 ~ Jiri Olsa <jolsa@kernel.org>
> hi,
> this patchset adds support to retrieve cookies from existing tracing
> links that still did not support it plus changes to bpftool to display
> them. It's leftover we discussed some time ago [1].
> 
> thanks,
> jirka
> 
> v2 changes:
>  - added review/ack tags
>  - fixed memory leak [Quentin]
>  - align the uapi fields properly [Yafang Shao]
> 
> 
> [1] https://lore.kernel.org/bpf/CALOAHbAZ6=A9j3VFCLoAC_WhgQKU7injMf06=cM2sU4Hi4Sx+Q@mail.gmail.com/
> ---
> Jiri Olsa (8):
>       bpf: Add cookie to perf_event bpf_link_info records
>       bpf: Store cookies in kprobe_multi bpf_link_info data
>       bpftool: Fix wrong free call in do_show_link
>       selftests/bpf: Add cookies check for kprobe_multi fill_link_info test
>       selftests/bpf: Add cookies check for perf_event fill_link_info test
>       selftests/bpf: Add fill_link_info test for perf event
>       bpftool: Display cookie for perf event link probes
>       bpftool: Display cookie for kprobe multi link
> 
>  include/uapi/linux/bpf.h                                |   7 ++++++
>  kernel/bpf/syscall.c                                    |   4 ++++
>  kernel/trace/bpf_trace.c                                |  15 +++++++++++++
>  tools/bpf/bpftool/link.c                                |  94 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------
>  tools/include/uapi/linux/bpf.h                          |   7 ++++++
>  tools/testing/selftests/bpf/prog_tests/fill_link_info.c | 114 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------
>  tools/testing/selftests/bpf/progs/test_fill_link_info.c |   6 +++++
>  7 files changed, 214 insertions(+), 33 deletions(-)

Reviewed-by: Quentin Monnet <quentin@isovalent.com>

Thank you!