From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Gergo Koteles <soyer@irl.hu>,
Shenghao Ding <shenghao-ding@ti.com>, Kevin Lu <kevin-lu@ti.com>,
Baojun Xu <baojun.xu@ti.com>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>
Cc: alsa-devel@alsa-project.org, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] ALSA: hda/tas2781: add debug statements to kcontrols
Date: Mon, 25 Mar 2024 17:01:18 -0500 [thread overview]
Message-ID: <377e0f33-697c-4baf-ac48-baff6199dd53@linux.intel.com> (raw)
In-Reply-To: <cbdc337b911bee0f80f805b936041fd59c1db54a.1711401621.git.soyer@irl.hu>
> +++ b/sound/pci/hda/tas2781_hda_i2c.c
> @@ -189,6 +189,9 @@ static int tasdevice_get_profile_id(struct snd_kcontrol *kcontrol,
>
> ucontrol->value.integer.value[0] = tas_priv->rcabin.profile_cfg_id;
>
> + dev_dbg(tas_priv->dev, "%s: %d\n", __func__,
Nit-pick: you don't need to add __func__ to dev_dbg logs, the user can
add the information with the dyndbg parameter, e.g.
options snd_intel_dspcfg dyndbg=+pmf
dev_err/warn don't have this functionality though so in those cases
there's no replacement for __func__
next prev parent reply other threads:[~2024-03-25 22:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 21:25 [PATCH 0/3] ALSA: hda/tas2781: fixes for 6.9-rc1 Gergo Koteles
2024-03-25 21:25 ` [PATCH 1/3] ALSA: hda/tas2781: remove digital gain kcontrol Gergo Koteles
2024-03-26 12:58 ` kernel test robot
2024-03-27 4:21 ` kernel test robot
2024-03-25 21:25 ` [PATCH 2/3] ALSA: hda/tas2781: add locks to kcontrols Gergo Koteles
2024-03-25 21:25 ` [PATCH 3/3] ALSA: hda/tas2781: add debug statements " Gergo Koteles
2024-03-25 22:01 ` Pierre-Louis Bossart [this message]
2024-03-25 22:07 ` Andy Shevchenko
2024-03-25 23:13 ` Gergo Koteles
2024-03-26 7:16 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=377e0f33-697c-4baf-ac48-baff6199dd53@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=baojun.xu@ti.com \
--cc=kevin-lu@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=shenghao-ding@ti.com \
--cc=soyer@irl.hu \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.