From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Aleksandar Markovic <aleksandar.markovic@rt-rk.com>,
qemu-devel@nongnu.org
Cc: noring@nocrew.org, smarkovic@wavecomp.com, arikalo@wavecomp.com,
amarkovic@wavecomp.com, alex.bennee@linaro.org,
aurelien@aurel32.net
Subject: Re: [Qemu-devel] [PATCH 1/2] tests: tcg: mips: Move source files to new location
Date: Tue, 1 Jan 2019 23:19:56 +0100 [thread overview]
Message-ID: <378e08d0-af95-bd2e-fea8-8a1fb542e59f@amsat.org> (raw)
In-Reply-To: <1545916380-12816-2-git-send-email-aleksandar.markovic@rt-rk.com>
Hi Aleksandar,
On 12/27/18 2:12 PM, Aleksandar Markovic wrote:
> From: Aleksandar Markovic <amarkovic@wavecomp.com>
>
> New directory organization is as follows:
>
> tests
> tcg
> mips
> user
> isa
> r5900
> ase
> dsp
> system
> ase
> dsp
>
> New file names are unique within tests/tcg/mips directory, to
> avoid potential name colision problems.
[...]
Since you said you are preparing a v2, could you split this huge patch
in smallers? One directory per patch seems an easy way to do it.
This way you can also delete the respective files from your patch 2 at
each step, and let your commits bisectables (else you let Makefile with
rules but no target to use them).
Thanks!
Phil.
next prev parent reply other threads:[~2019-01-01 22:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-27 13:12 [Qemu-devel] [PATCH 0/2] tests: Reorganize MIPS TCG directories and files Aleksandar Markovic
2018-12-27 13:12 ` [Qemu-devel] [PATCH 1/2] tests: tcg: mips: Move source files to new location Aleksandar Markovic
2018-12-31 19:43 ` Philippe Mathieu-Daudé
2019-01-01 22:19 ` Philippe Mathieu-Daudé [this message]
2018-12-27 13:13 ` [Qemu-devel] [PATCH 2/2] tests: tcg: mips: Remove old directories after reorganization Aleksandar Markovic
2018-12-27 22:02 ` [Qemu-devel] [PATCH 0/2] tests: Reorganize MIPS TCG directories and files Philippe Mathieu-Daudé
2018-12-28 9:29 ` Aleksandar Markovic
2019-01-03 20:06 ` Eric Blake
2019-01-03 20:36 ` Aleksandar Markovic
2019-01-04 16:46 Aleksandar Markovic
2019-01-04 16:46 ` [Qemu-devel] [PATCH 1/2] tests: tcg: mips: Move source files to new location Aleksandar Markovic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=378e08d0-af95-bd2e-fea8-8a1fb542e59f@amsat.org \
--to=f4bug@amsat.org \
--cc=aleksandar.markovic@rt-rk.com \
--cc=alex.bennee@linaro.org \
--cc=amarkovic@wavecomp.com \
--cc=arikalo@wavecomp.com \
--cc=aurelien@aurel32.net \
--cc=noring@nocrew.org \
--cc=qemu-devel@nongnu.org \
--cc=smarkovic@wavecomp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.