From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: Takashi Iwai <tiwai@suse.de>,
Emmanuel Gil Peyrot <linkmauve@jabberfr.org>
Cc: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH - hwmixvolume 1/9] hwmixvolume: replace PyGTK with gobject-introspection
Date: Sat, 11 Aug 2018 13:33:42 +0900 [thread overview]
Message-ID: <37f2df60-f5ec-f6bb-2861-c586681822de@sakamocchi.jp> (raw)
In-Reply-To: <s5h36vm2rtc.wl-tiwai@suse.de>
Hi,
On Aug 10 2018 23:56, Takashi Iwai wrote:
> On Wed, 08 Aug 2018 17:56:29 +0200,
> Emmanuel Gil Peyrot wrote:
>>
>> This doesn’t work yet, we require Gtk 3.0 rather than 2.0 and the API
>> changed quite a lot.
>>
>> Signed-off-by: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
>
> Thanks for the patches. Most of changes look good, but also most of
> patches have no change log at all. That's already a bad sign.
>
> Could you give some details, especially why the change is needed, in
> each patch and resubmit as a patchset? At best, send with a cover
> letter and a thread as a patch set at the next time (git-send-email
> can manage it well).
I'm familiar with g-i. If you need reviewers, please add me to CC list
in next time you post, freely.
Regards
Takashi Sakamoto
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2018-08-11 4:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180808155637.5592-1-linkmauve@jabberfr.org>
2018-08-08 15:56 ` [PATCH - hwmixvolume 1/9] hwmixvolume: replace PyGTK with gobject-introspection Emmanuel Gil Peyrot
2018-08-10 14:56 ` Takashi Iwai
2018-08-10 15:29 ` Emmanuel Gil Peyrot
2018-08-11 4:33 ` Takashi Sakamoto [this message]
2018-08-14 4:24 ` Takashi Sakamoto
2018-08-08 15:56 ` [PATCH - hwmixvolume 2/9] hwmixvolume: switch to GTK+ 3.0 Emmanuel Gil Peyrot
2018-08-08 15:56 ` [PATCH - hwmixvolume 3/9] hwmixvolume: use four spaces instead of one tab for indent Emmanuel Gil Peyrot
2018-08-08 15:56 ` [PATCH - hwmixvolume 4/9] hwmixvolume: use a with context to open files Emmanuel Gil Peyrot
2018-08-14 3:59 ` Takashi Sakamoto
2018-08-15 15:36 ` Takashi Sakamoto
2018-08-08 15:56 ` [PATCH - hwmixvolume 5/9] hwmixvolume: replace deprecated Gtk.HScale with Gtk.Scale Emmanuel Gil Peyrot
2018-08-08 15:56 ` [PATCH - hwmixvolume 6/9] hwmixvolume: fix deprecation warnings given by G_ENABLE_DIAGNOSTIC=1 Emmanuel Gil Peyrot
2018-08-08 15:56 ` [PATCH - hwmixvolume 7/9] hwmixvolume: switch the shebang to python, as it is now compatible with both 2 and 3 Emmanuel Gil Peyrot
2018-08-08 15:56 ` [PATCH - hwmixvolume 8/9] hwmixvolume: add my copyright Emmanuel Gil Peyrot
2018-08-08 15:56 ` [PATCH - hwmixvolume 9/9] hwmixvolume: mention the new dependencies in the README Emmanuel Gil Peyrot
2018-08-14 3:43 ` Takashi Sakamoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37f2df60-f5ec-f6bb-2861-c586681822de@sakamocchi.jp \
--to=o-takashi@sakamocchi.jp \
--cc=alsa-devel@alsa-project.org \
--cc=linkmauve@jabberfr.org \
--cc=linkmauve@linkmauve.fr \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.