From: Julien Grall <julien@xen.org>
To: Penny Zheng <Penny.Zheng@arm.com>, xen-devel@lists.xenproject.org
Cc: wei.chen@arm.com, Stefano Stabellini <sstabellini@kernel.org>,
Bertrand Marquis <bertrand.marquis@arm.com>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v1 04/13] xen/arm: expand shm_membank for unprovided host address
Date: Sun, 8 Jan 2023 12:13:21 +0000 [thread overview]
Message-ID: <3832d94f-6856-82b3-ea64-a9e79460c547@xen.org> (raw)
In-Reply-To: <20221115025235.1378931-5-Penny.Zheng@arm.com>
Hi Penny,
On 15/11/2022 02:52, Penny Zheng wrote:
> When host address is not provided in "xen,shared-mem", we let Xen
> automatically allocate requested static shared memory from heap, and it
> stands good chance of having multiple host memory banks allocated for the
> requested static shared memory as a result. Therefore current membank is not
> going to cover it.
>
> This commit introduces a new field "mem" to cover both scenarios.
> "struct membank" is used when host address is provided, whereas
> "struct meminfo" shall be used when host address not provided.
From this patch, it is not clear to me how a user can know which part
of the union should be used.
However... I am not entirely sure why you need to create a union because
in your new structure you can fit one bank.
Cheers,
--
Julien Grall
next prev parent reply other threads:[~2023-01-08 12:13 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 2:52 [PATCH V1 00/13 for 4.17-post] Follow-up static shared memory Penny Zheng
2022-11-15 2:52 ` [PATCH v1 01/13] xen/arm: re-arrange the static shared memory region Penny Zheng
2023-01-08 11:44 ` Julien Grall
2023-01-09 7:48 ` Penny Zheng
2023-01-09 10:01 ` Julien Grall
2023-02-07 20:55 ` Stewart Hildebrand
2023-02-14 9:56 ` Penny Zheng
2022-11-15 2:52 ` [PATCH v1 02/13] xen/arm: switch to use shm_membank as function parameter Penny Zheng
2022-11-15 6:58 ` Jeungwoo Yoo
2023-01-08 11:56 ` Julien Grall
2022-11-15 2:52 ` [PATCH v1 03/13] xen/arm: introduce allocate_domheap_memory and guest_physmap_memory Penny Zheng
2023-02-07 20:56 ` Stewart Hildebrand
2022-11-15 2:52 ` [PATCH v1 04/13] xen/arm: expand shm_membank for unprovided host address Penny Zheng
2023-01-08 12:13 ` Julien Grall [this message]
2023-01-08 12:54 ` Julien Grall
2022-11-15 2:52 ` [PATCH v1 05/13] xen/arm: allocate shared memory from heap when host address not provided Penny Zheng
2023-01-08 12:22 ` Julien Grall
2023-01-09 7:50 ` Penny Zheng
2023-01-09 10:07 ` Julien Grall
2023-02-07 20:57 ` Stewart Hildebrand
2022-11-15 2:52 ` [PATCH v1 06/13] xen/arm: assign shared memory to owner " Penny Zheng
2023-01-08 12:52 ` Julien Grall
2023-01-09 7:49 ` Penny Zheng
2023-01-09 10:57 ` Julien Grall
2023-01-09 11:58 ` Penny Zheng
2023-01-09 18:23 ` Julien Grall
2023-01-10 3:38 ` Penny Zheng
2023-01-10 12:47 ` Julien Grall
2023-01-18 6:09 ` Penny Zheng
2023-02-07 20:58 ` Stewart Hildebrand
2022-11-15 2:52 ` [PATCH v1 07/13] xen/arm: map shared memory to borrower " Penny Zheng
2022-11-15 2:52 ` [PATCH v1 08/13] xen/arm: use paddr_assigned to indicate whether host address is provided Penny Zheng
2022-11-15 2:52 ` [PATCH v1 09/13] xen/arm: refine docs about static shared memory Penny Zheng
2022-11-15 2:52 ` [PATCH v1 10/13] xen/arm: introduce "xen,offset" feature Penny Zheng
2022-11-15 2:52 ` [PATCH v1 11/13] xen/arm: implement "xen,offset" feature when host address provided Penny Zheng
2022-11-15 2:52 ` [PATCH v1 12/13] xen/arm: implement "xen,offset" feature when host address not provided Penny Zheng
2022-11-15 2:52 ` [PATCH v1 13/13] xen: make static shared memory supported in SUPPORT.md Penny Zheng
2023-01-08 13:18 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3832d94f-6856-82b3-ea64-a9e79460c547@xen.org \
--to=julien@xen.org \
--cc=Penny.Zheng@arm.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=bertrand.marquis@arm.com \
--cc=sstabellini@kernel.org \
--cc=wei.chen@arm.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.