From: "Coelho, Luciano" <luciano.coelho@intel.com>
To: "kuba@kernel.org" <kuba@kernel.org>,
"johannes@sipsolutions.net" <johannes@sipsolutions.net>,
"arnd@kernel.org" <arnd@kernel.org>,
"kvalo@codeaurora.org" <kvalo@codeaurora.org>,
"stf_xl@wp.pl" <stf_xl@wp.pl>,
"davem@davemloft.net" <davem@davemloft.net>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"Beker, Ayala" <ayala.beker@intel.com>,
"Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"arnd@arndb.de" <arnd@arndb.de>
Subject: Re: [PATCH 1/3] iwlwifi: fix LED dependencies
Date: Tue, 7 Dec 2021 10:52:03 +0000 [thread overview]
Message-ID: <38b5bff4e24db266537bb8e3161d87c603c020f2.camel@intel.com> (raw)
In-Reply-To: <dc7d43b96cd1a40654bb2da009ea515b8ded40c3.camel@sipsolutions.net>
On Tue, 2021-12-07 at 11:49 +0100, Johannes Berg wrote:
> On Tue, 2021-12-07 at 11:16 +0100, Johannes Berg wrote:
> > On Tue, 2021-12-07 at 11:14 +0100, Johannes Berg wrote:
> > > On Sat, 2021-12-04 at 18:38 +0100, Arnd Bergmann wrote:
> > > >
> > > > config IWLWIFI_LEDS
> > > > bool
> > > > - depends on LEDS_CLASS=y || LEDS_CLASS=IWLWIFI
> > > > + depends on LEDS_CLASS=y || LEDS_CLASS=MAC80211
> > > >
> > >
> > > Hm. Can we really not have this if LEDS_CLASS=n?
> > >
> >
> > Well, umm. That wouldn't make sense for IWLWIFI_LEDS, sorry.
> >
> > Might be simpler to express this as "depends on MAC80211_LEDS" which has
> > the same condition, and it feels like that makes more sense than
> > referencing MAC80211 here?
> >
>
> Hm, maybe not. Sorry for the monologue here - but MAC80211_LEDS is user
> selectable, and so I guess that's a different thing.
Thanks for checking this, Johannes!
So, if you think we can take Arnd's patch, Kalle has my ack:
Acked-by: Luca Coelho <luciano.coelho@intel.com>
--
Cheers,
Luca.
next prev parent reply other threads:[~2021-12-07 10:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-04 17:38 [PATCH 1/3] iwlwifi: fix LED dependencies Arnd Bergmann
2021-12-04 17:38 ` [PATCH 2/3] brcmsmac: rework " Arnd Bergmann
2021-12-04 17:38 ` [PATCH 3/3] mt76: mt7921: fix build regression Arnd Bergmann
2021-12-04 17:38 ` Arnd Bergmann
2021-12-04 17:38 ` Arnd Bergmann
2021-12-04 17:51 ` Felix Fietkau
2021-12-04 17:51 ` Felix Fietkau
2021-12-04 17:51 ` Felix Fietkau
2021-12-07 7:04 ` [PATCH 1/3] iwlwifi: fix LED dependencies Kalle Valo
2021-12-07 10:14 ` Johannes Berg
2021-12-07 10:16 ` Johannes Berg
2021-12-07 10:49 ` Johannes Berg
2021-12-07 10:52 ` Coelho, Luciano [this message]
2021-12-08 18:17 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38b5bff4e24db266537bb8e3161d87c603c020f2.camel@intel.com \
--to=luciano.coelho@intel.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=ayala.beker@intel.com \
--cc=davem@davemloft.net \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stf_xl@wp.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.