From: "Mkrtchyan, Tigran" <tigran.mkrtchyan@desy.de>
To: Tom Haynes <loghyr@gmail.com>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
bfields <bfields@redhat.com>,
linux-nfs <linux-nfs@vger.kernel.org>
Subject: Re: [pynfs 00/10] Misc Fixes, primarily LAYOUTRETURN
Date: Fri, 18 Dec 2020 17:50:16 +0100 (CET) [thread overview]
Message-ID: <390162557.5382045.1608310216661.JavaMail.zimbra@desy.de> (raw)
In-Reply-To: <129D549F-66DC-43FE-B303-042442CDAAC8@gmail.com>
Let correct myself: some of them fail due to python3.
Tigran.
----- Original Message -----
> From: "Tom Haynes" <loghyr@gmail.com>
> To: "J. Bruce Fields" <bfields@fieldses.org>
> Cc: "Tigran Mkrtchyan" <tigran.mkrtchyan@desy.de>, "bfields" <bfields@redhat.com>, "linux-nfs"
> <linux-nfs@vger.kernel.org>
> Sent: Friday, 18 December, 2020 17:38:54
> Subject: Re: [pynfs 00/10] Misc Fixes, primarily LAYOUTRETURN
>> On Dec 18, 2020, at 8:37 AM, J. Bruce Fields <bfields@fieldses.org> wrote:
>>
>> On Fri, Dec 18, 2020 at 05:23:58PM +0100, Mkrtchyan, Tigran wrote:
>>>
>>> I run the tests. They fail due to python3 incompatibility:
>>
>> Thanks! I can't reproduce these, I assume because they're failing too
>> early?:
>>
>> FFLA1 st_flex.testFlexLayoutTestAccess : RUNNING
>> FFLA1 st_flex.testFlexLayoutTestAccess : FAILURE
>> OP_LAYOUTGET should return NFS4_OK, instead got
>> NFS4ERR_LAYOUTUNAVAILABLE
>>
>> They're probably easy fixes, but I'd rather leave them up to somebody
>> that can test the result. Patches on top of these would be best.
>>
>
>
> I’ll do that - but note that they were failing before my patch set.
>
>
>> --b.
>>
>>>
>>> FFST1 st_flex.testStateid1 : PASS
>>> FFLA1 st_flex.testFlexLayoutTestAccess : FAILURE
>>> Expected uid_rd != b'17', got b'17'
>>> FFLG2 st_flex.testFlexLayoutStress : FAILURE
>>> TypeError: can only concatenate str (not "bytes") to
>>> str
>>> FFLS3 st_flex.testFlexLayoutStatsStraight : FAILURE
>>> TypeError: can only concatenate str (not "bytes") to
>>> str
>>> FFLS1 st_flex.testFlexLayoutStatsSmall : FAILURE
>>> TypeError: can't concat str to bytes
>>> FFLS2 st_flex.testFlexLayoutStatsReset : FAILURE
>>> TypeError: can only concatenate str (not "bytes") to
>>> str
>>> FFLS4 st_flex.testFlexLayoutStatsOverflow : FAILURE
>>> TypeError: can only concatenate str (not "bytes") to
>>> str
>>> FFLORSTALEWRITE st_flex.testFlexLayoutReturnStaleWrite : FAILURE
>>> OP_LAYOUTGET should return NFS4_OK or NFS4ERR_DELAY or
>>> NFS4ERR_STALE, instead got NFS4ERR_LAYOUTUNAVAILABLE
>>> FFLORSTALEREAD st_flex.testFlexLayoutReturnStaleRead : FAILURE
>>> OP_LAYOUTGET should return NFS4_OK, instead got
>>> NFS4ERR_LAYOUTTRYLATER
>>> FFLORSERVERFAULTWRITE st_flex.testFlexLayoutReturnServerFaultWrite : FAILURE
>>> OP_LAYOUTGET should return NFS4_OK or NFS4ERR_DELAY or
>>> NFS4ERR_SERVERFAULT, instead got
>>> NFS4ERR_LAYOUTUNAVAILABLE
>>> FFLORSERVERFAULTREAD st_flex.testFlexLayoutReturnServerFaultRead : FAILURE
>>> OP_LAYOUTGET should return NFS4_OK, instead got
>>> NFS4ERR_LAYOUTTRYLATER
>>> FFLORNXIOWRITE st_flex.testFlexLayoutReturnNxioWrite : FAILURE
>>> OP_LAYOUTGET should return NFS4_OK or NFS4ERR_DELAY or
>>> NFS4ERR_NXIO, instead got NFS4ERR_LAYOUTUNAVAILABLE
>>> FFLORNXIOREAD st_flex.testFlexLayoutReturnNxioRead : FAILURE
>>> OP_LAYOUTGET should return NFS4_OK, instead got
>>> NFS4ERR_LAYOUTTRYLATER
>>> FFLORNOSPCWRITE st_flex.testFlexLayoutReturnNospcWrite : FAILURE
>>> OP_LAYOUTGET should return NFS4_OK or NFS4ERR_DELAY or
>>> NFS4ERR_NOSPC, instead got NFS4ERR_LAYOUTUNAVAILABLE
>>> FFLORNOSPC st_flex.testFlexLayoutReturnNospcRead : FAILURE
>>> OP_LAYOUTGET should return NFS4_OK, instead got
>>> NFS4ERR_LAYOUTUNAVAILABLE
>>> FFLORIOWRITE st_flex.testFlexLayoutReturnIoWrite : FAILURE
>>> OP_LAYOUTGET should return NFS4_OK or NFS4ERR_DELAY or
>>> NFS4ERR_IO, instead got NFS4ERR_LAYOUTUNAVAILABLE
>>> FFLORIOREAD st_flex.testFlexLayoutReturnIoRead : FAILURE
>>> OP_LAYOUTGET should return NFS4_OK, instead got
>>> NFS4ERR_LAYOUTTRYLATER
>>> FFLORFBIGWRITE st_flex.testFlexLayoutReturnFbigWrite : FAILURE
>>> OP_LAYOUTGET should return NFS4_OK or NFS4ERR_DELAY or
>>> NFS4ERR_FBIG, instead got NFS4ERR_LAYOUTUNAVAILABLE
>>> FFLORFBIG st_flex.testFlexLayoutReturnFbigRead : FAILURE
>>> OP_LAYOUTGET should return NFS4_OK, instead got
>>> NFS4ERR_LAYOUTUNAVAILABLE
>>> FFLORDELAYWRITE st_flex.testFlexLayoutReturnDelayWrite : FAILURE
>>> OP_LAYOUTGET should return NFS4_OK or NFS4ERR_DELAY,
>>> instead got NFS4ERR_LAYOUTUNAVAILABLE
>>> FFLORDELAYREAD st_flex.testFlexLayoutReturnDelayRead : FAILURE
>>> OP_LAYOUTGET should return NFS4_OK, instead got
>>> NFS4ERR_LAYOUTTRYLATER
>>> FFLORACCESSWRITE st_flex.testFlexLayoutReturnAccessWrite : FAILURE
>>> OP_LAYOUTGET should return NFS4_OK or NFS4ERR_DELAY or
>>> NFS4ERR_ACCESS, instead got NFS4ERR_LAYOUTUNAVAILABLE
>>> FFLORACCESSREAD st_flex.testFlexLayoutReturnAccessRead : FAILURE
>>> OP_LAYOUTGET should return NFS4_OK, instead got
>>> NFS4ERR_LAYOUTTRYLATER
>>> FFLOR100 st_flex.testFlexLayoutReturn100 : FAILURE
>>> NameError: name 'xrange' is not defined
>>> FFLOOS st_flex.testFlexLayoutOldSeqid : FAILURE
>>> TypeError: can only concatenate str (not "bytes") to
>>> str
>>> FFGLO1 st_flex.testFlexGetLayout : FAILURE
>>> OP_LAYOUTGET should return NFS4_OK, instead got
>>> NFS4ERR_LAYOUTTRYLATER
>>> FFGDI1 st_flex.testFlexGetDevInfo : FAILURE
>>> TypeError: can only concatenate str (not "bytes") to
>>> str
>>>
>>>
>>> Regards,
>>> Tigran.
>>>
>>>
>>>
>>> ----- Original Message -----
>>>> From: "J. Bruce Fields" <bfields@fieldses.org>
>>>> To: "Tom Haynes" <loghyr@gmail.com>
>>>> Cc: "bfields" <bfields@redhat.com>, "linux-nfs" <linux-nfs@vger.kernel.org>
>>>> Sent: Friday, 18 December, 2020 15:46:05
>>>> Subject: Re: [pynfs 00/10] Misc Fixes, primarily LAYOUTRETURN
>>>
>>>> On Wed, Dec 16, 2020 at 04:35:06PM -0800, Tom Haynes wrote:
>>>>> Hi Bruce,
>>>>>
>>>>> Here are a series of patches that Hamerspace has applied to the
>>>>> flex files testing.
>>>>
>>>> Thanks, applying.
>>>>
>>>> I'm pretty hands-off when it comes to pynfs tests I don't personally
>>>> run. If they work for you then I'm probably fine with them....
>>>>
>>>> --b.
>>>>
>>>>>
>>>>> Thanks,
>>>>> Tom
>>>>>
>>>>> Jean Spector (2):
>>>>> st_flex.py - Added tests for LAYOUTRETURN with errors
>>>>> st_flex.py - Fixed flag names
>>>>>
>>>>> Tom Haynes (7):
>>>>> Close the file for SEQ10b
>>>>> flexfiles: Fix up the layout error handling to reflect the previous
>>>>> error
>>>>> st_flex: Reduce the layoutstats period to make tests finish in a sane
>>>>> time
>>>>> st_flex: Fix up test names
>>>>> st_flex: Only do 100 layoutget/return in loop
>>>>> st_flex: We can't return the layout without a layout stateid
>>>>> st_flex: Fixup check for error in layoutget_return()
>>>>>
>>>>> Trond Myklebust (1):
>>>>> Fix testFlexLayoutOldSeqid
>>>>>
>>>>> nfs4.1/server41tests/st_flex.py | 651 +++++++++++++++++++++++++---
>>>>> nfs4.1/server41tests/st_sequence.py | 5 +
>>>>> 2 files changed, 588 insertions(+), 68 deletions(-)
>>>>>
>>>>> --
> >>>> 2.26.2
prev parent reply other threads:[~2020-12-18 16:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 0:35 [pynfs 00/10] Misc Fixes, primarily LAYOUTRETURN Tom Haynes
2020-12-17 0:35 ` [pynfs 01/10] st_flex.py - Added tests for LAYOUTRETURN with errors Tom Haynes
2020-12-17 0:35 ` [pynfs 02/10] st_flex.py - Fixed flag names Tom Haynes
2020-12-17 0:35 ` [pynfs 03/10] Close the file for SEQ10b Tom Haynes
2020-12-18 16:43 ` J. Bruce Fields
2020-12-21 2:42 ` Thomas Haynes
2020-12-21 2:46 ` J. Bruce Fields
2020-12-17 0:35 ` [pynfs 04/10] flexfiles: Fix up the layout error handling to reflect the previous error Tom Haynes
2020-12-17 0:35 ` [pynfs 05/10] Fix testFlexLayoutOldSeqid Tom Haynes
2020-12-17 0:35 ` [pynfs 06/10] st_flex: Reduce the layoutstats period to make tests finish in a sane time Tom Haynes
2020-12-17 0:35 ` [pynfs 07/10] st_flex: Fix up test names Tom Haynes
2020-12-17 0:35 ` [pynfs 08/10] st_flex: Only do 100 layoutget/return in loop Tom Haynes
2020-12-17 0:35 ` [pynfs 09/10] st_flex: We can't return the layout without a layout stateid Tom Haynes
2020-12-17 0:35 ` [pynfs 10/10] st_flex: Fixup check for error in layoutget_return() Tom Haynes
2020-12-18 14:46 ` [pynfs 00/10] Misc Fixes, primarily LAYOUTRETURN J. Bruce Fields
2020-12-18 16:23 ` Mkrtchyan, Tigran
2020-12-18 16:37 ` J. Bruce Fields
2020-12-18 16:38 ` Thomas Haynes
2020-12-18 16:50 ` Mkrtchyan, Tigran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=390162557.5382045.1608310216661.JavaMail.zimbra@desy.de \
--to=tigran.mkrtchyan@desy.de \
--cc=bfields@fieldses.org \
--cc=bfields@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=loghyr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.