From: Tomasz Figa <t.figa@samsung.com>
To: Vikas Sajjan <vikas.sajjan@linaro.org>
Cc: "linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"kgene.kim" <kgene.kim@samsung.com>,
Patch Tracking <patches@linaro.org>,
linaro-kernel@lists.linaro.org
Subject: Re: [PATCH V3 0/2] Add RTC DT node to Exynos5420 SoC and Fix RTC DT node name for 5250 Soc
Date: Wed, 14 Aug 2013 14:27:03 +0200 [thread overview]
Message-ID: <3941559.QnWYLUF6Gp@amdc1227> (raw)
In-Reply-To: <CAD025yRSX-8Yn1OKo7mZ_qtU057GRr=FOJ7ro-Of+2ePqoAHvA@mail.gmail.com>
On Wednesday 14 of August 2013 17:37:47 Vikas Sajjan wrote:
> Hi Tomasz,
>
> On 14 August 2013 17:00, Tomasz Figa <t.figa@samsung.com> wrote:
> > Hi Vikas,
> >
> > On Wednesday 14 of August 2013 16:32:59 Vikas Sajjan wrote:
> >> changes since v2:
> >> - split the 5250 related modifications into a separate patch.
> >
> > I'm not sure whether Kukjin's comment was about this, as it introduces
> > a
> > short bisect breakage between patch 1 and patch 2 from this series.
> >
> > IMHO it would be more sensible to make first patch simply fix name of
> > the node and then a separate patch adding the rtc node for exynos5420.
> Are you saying that
> patch 1: should contain modifications for exynos5.dtsi and
> exynos5250.dtsi ( basically the RTC name change and status as
> "okay")
> patch 2: should contain modifications only for exynos5420.dtsi ( new
> RTC DT node )
Oh, I forgot about the status property. So ideally there should be 3
patches:
- patch 1 changing exynos5.dtsi and exynos5250.dtsi to fix RTC node name,
- patch 2 adding status="okay" to exynos5250.dtsi,
- patch 3 adding RTC node to exynos5420.dtsi.
Best regards,
Tomasz
prev parent reply other threads:[~2013-08-14 12:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-14 11:02 [PATCH V3 0/2] Add RTC DT node to Exynos5420 SoC and Fix RTC DT node name for 5250 Soc Vikas Sajjan
2013-08-14 11:03 ` [PATCH V3 1/2] ARM: dts: Add RTC DT node to Exynos5420 SoC Vikas Sajjan
2013-08-14 11:03 ` [PATCH V3 2/2] ARM: dts: Fix the RTC DT node name for Exynos5250 SoC Vikas Sajjan
2013-08-14 11:30 ` [PATCH V3 0/2] Add RTC DT node to Exynos5420 SoC and Fix RTC DT node name for 5250 Soc Tomasz Figa
2013-08-14 12:07 ` Vikas Sajjan
2013-08-14 12:27 ` Tomasz Figa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3941559.QnWYLUF6Gp@amdc1227 \
--to=t.figa@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=patches@linaro.org \
--cc=vikas.sajjan@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.