From: Bastien Nocera <hadess@hadess.net>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Marcin Niestroj <m.niestroj@grinn-global.com>,
Antonio Ospite <ao2@ao2.it>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
Subject: Re: [PATCH v3 3/3] Input: goodix - use generic touchscreen_properties
Date: Sat, 27 Jan 2018 02:19:00 +0100 [thread overview]
Message-ID: <394F8C1E-A963-4AB2-A653-B23A7D07E1AE@hadess.net> (raw)
In-Reply-To: <CAKdAkRTcsTOqj_jT7uu09k5i82wDEB0Fm-sb4TrNviwKbeb9iw@mail.gmail.com>
> On 27 Jan 2018, at 00:57, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
>
>> On Fri, Jan 26, 2018 at 3:48 PM, Bastien Nocera <hadess@hadess.net> wrote:
>>> On Fri, 2018-01-26 at 11:19 -0800, Dmitry Torokhov wrote:
>>> Can you please try the version below (note that I sqashed all your 3
>>> patches in one as, as I mentioed, I do not see why they need to be
>>> split
>>> in the first place).
>>
>> It was easier to read, and backport. Patch 1 and 2 at least are easily
>> backportable, and "easy" fixes on top of the existing code. Breakages
>> would be easier to spot with the 3 separate fixes, and that's how I'd
>> prefer it if it's not too much bother.
>
> There is nothing to read if you drop the patch 2, as it is something
> that was done and immediately deleted.
It’s easier to backport and understand. Fine if you don’t want it. I’d rather it was still there.
>
> Thanks.
>
> --
> Dmitry
next prev parent reply other threads:[~2018-01-27 1:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-25 19:08 [PATCH v3 0/3] Input: goodix - fixes and conversion to touchscreen_properties Marcin Niestroj
2018-01-25 19:08 ` [PATCH v3 1/3] Input: goodix - fix reported range Marcin Niestroj
2018-01-26 9:44 ` Bastien Nocera
2018-01-25 19:08 ` [PATCH v3 2/3] Input: goodix - fix simultaneous axes inversion and swap Marcin Niestroj
2018-01-26 9:44 ` Bastien Nocera
2018-01-25 19:08 ` [PATCH v3 3/3] Input: goodix - use generic touchscreen_properties Marcin Niestroj
2018-01-26 9:44 ` Bastien Nocera
2018-01-26 19:19 ` Dmitry Torokhov
2018-01-26 23:48 ` Bastien Nocera
2018-01-26 23:57 ` Dmitry Torokhov
2018-01-27 1:19 ` Bastien Nocera [this message]
2018-01-29 16:49 ` Marcin Niestroj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=394F8C1E-A963-4AB2-A653-B23A7D07E1AE@hadess.net \
--to=hadess@hadess.net \
--cc=ao2@ao2.it \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=m.niestroj@grinn-global.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.