Re: [PATCH] meson: Only generate trace files for selected targets

From: Paolo Bonzini <pbonzini@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [PATCH] meson: Only generate trace files for selected targets
Date: Wed, 24 Feb 2021 13:26:24 +0100	[thread overview]
Message-ID: <39cc99dd-54d5-9dd1-d66a-7947686dbada@redhat.com> (raw)
In-Reply-To: <20210224120923.3154325-1-philmd@redhat.com>

On 24/02/21 13:09, Philippe Mathieu-Daudé wrote:
> We don't need to generate trace files for targets we
> are not building. Restrict the the ones selected.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>   meson.build | 10 +---------
>   1 file changed, 1 insertion(+), 9 deletions(-)
> 
> diff --git a/meson.build b/meson.build
> index 05a67c20d93..c9b0433667d 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -1826,15 +1826,6 @@
>     trace_events_subdirs += [
>       'accel/tcg',
>       'hw/core',
> -    'target/arm',
> -    'target/hppa',
> -    'target/i386',
> -    'target/i386/kvm',
> -    'target/mips',
> -    'target/ppc',
> -    'target/riscv',
> -    'target/s390x',
> -    'target/sparc',
>     ]
>   endif
>   
> @@ -2166,6 +2157,7 @@
>     t = target_arch[arch].apply(config_target, strict: false)
>     arch_srcs += t.sources()
>     arch_deps += t.dependencies()
> +  trace_events_subdirs += ['target' / arch]
>   
>     target_common = common_ss.apply(config_target, strict: false)
>     objects = common_all.extract_objects(target_common.sources())
> 

Is this still okay if there is no trace-events file for a given arch?

Paolo