From: Jan Beulich <jbeulich@suse.com>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v4 2/6] amd-vi: set IOMMU page table levels based on guest reported paddr width
Date: Thu, 21 Dec 2023 09:13:39 +0100 [thread overview]
Message-ID: <3a580b22-7ff2-4a60-a3c0-0cb03deef6ac@suse.com> (raw)
In-Reply-To: <20231220134346.22430-3-roger.pau@citrix.com>
On 20.12.2023 14:43, Roger Pau Monne wrote:
> --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c
> +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c
> @@ -359,21 +359,17 @@ int __read_mostly amd_iommu_min_paging_mode = 1;
> static int cf_check amd_iommu_domain_init(struct domain *d)
> {
> struct domain_iommu *hd = dom_iommu(d);
> + int pglvl = amd_iommu_get_paging_mode(
> + 1UL << (domain_max_paddr_bits(d) - PAGE_SHIFT));
Nit: Considering the "pending" open parenthesis, I think this line
needs indenting one level further. I'll make the adjustment while
committing, unless I hear objections pretty soon.
Jan
next prev parent reply other threads:[~2023-12-21 8:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 13:43 [PATCH v4 0/6] x86/iommu: improve setup time of hwdom IOMMU Roger Pau Monne
2023-12-20 13:43 ` [PATCH v4 1/6] x86/p2m: move and rename paging_max_paddr_bits() Roger Pau Monne
2023-12-20 13:43 ` [PATCH v4 2/6] amd-vi: set IOMMU page table levels based on guest reported paddr width Roger Pau Monne
2023-12-21 8:13 ` Jan Beulich [this message]
2023-12-20 13:43 ` [PATCH v4 3/6] x86/iommu: introduce a rangeset to perform hwdom IOMMU setup Roger Pau Monne
2024-01-09 11:29 ` Jan Beulich
2023-12-20 13:43 ` [PATCH v4 4/6] x86/iommu: remove regions not to be mapped Roger Pau Monne
2023-12-20 13:43 ` [PATCH v4 5/6] x86/iommu: switch hwdom IOMMU to use a rangeset Roger Pau Monne
2023-12-20 13:43 ` [PATCH v4 6/6] x86/iommu: cleanup unused functions Roger Pau Monne
2023-12-21 10:12 ` [PATCH] x86/iommu: add CHANGELOG entry for hwdom setup time improvements Roger Pau Monne
2023-12-21 10:23 ` Jan Beulich
2023-12-21 11:24 ` Roger Pau Monné
2024-01-09 11:38 ` [PATCH v4 0/6] x86/iommu: improve setup time of hwdom IOMMU Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a580b22-7ff2-4a60-a3c0-0cb03deef6ac@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.