Re: [PATCH net v3 2/3] net: rswitch: Fix return value in rswitch_start_xmit()

From: Wojciech Drewek <wojciech.drewek@intel.com>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	<s.shtylyov@omp.ru>, <davem@davemloft.net>, <edumazet@google.com>,
	<kuba@kernel.org>, <pabeni@redhat.com>
Cc: <netdev@vger.kernel.org>, <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH net v3 2/3] net: rswitch: Fix return value in rswitch_start_xmit()
Date: Wed, 22 Nov 2023 11:13:14 +0100	[thread overview]
Message-ID: <3ae8b479-9183-4bf1-b8da-7c91955360d6@intel.com> (raw)
In-Reply-To: <20231122051143.3660780-3-yoshihiro.shimoda.uh@renesas.com>


On 22.11.2023 06:11, Yoshihiro Shimoda wrote:
> This .ndo_start_xmit() function should return netdev_tx_t value,
> not -ENOMEM. So, fix it.
> 
> Fixes: 33f5d733b589 ("net: renesas: rswitch: Improve TX timestamp accuracy")
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---

Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>

>  drivers/net/ethernet/renesas/rswitch.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/renesas/rswitch.c b/drivers/net/ethernet/renesas/rswitch.c
> index d53d90020904..45bf9808c143 100644
> --- a/drivers/net/ethernet/renesas/rswitch.c
> +++ b/drivers/net/ethernet/renesas/rswitch.c
> @@ -1535,7 +1535,7 @@ static netdev_tx_t rswitch_start_xmit(struct sk_buff *skb, struct net_device *nd
>  		ts_info = kzalloc(sizeof(*ts_info), GFP_ATOMIC);
>  		if (!ts_info) {
>  			dma_unmap_single(ndev->dev.parent, dma_addr, skb->len, DMA_TO_DEVICE);
> -			return -ENOMEM;
> +			return ret;
>  		}
>  
>  		skb_shinfo(skb)->tx_flags |= SKBTX_IN_PROGRESS;