From: "Coelho, Luciano" <luciano.coelho@intel.com>
To: "johannes@sipsolutions.net" <johannes@sipsolutions.net>,
"kuba@kernel.org" <kuba@kernel.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"greearb@candelatech.com" <greearb@candelatech.com>,
"edumazet@google.com" <edumazet@google.com>,
"eric.dumazet@gmail.com" <eric.dumazet@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net] iwlwifi: provide gso_type to GSO packets
Date: Wed, 27 Jan 2021 06:02:12 +0000 [thread overview]
Message-ID: <3aedacff5e5c37a735a2a6da2a8042efcd530eb2.camel@intel.com> (raw)
In-Reply-To: <596880294af8224f2f28311c39491bdfa3b39f2e.camel@sipsolutions.net>
On Tue, 2021-01-26 at 21:55 +0100, Johannes Berg wrote:
> On Tue, 2021-01-26 at 12:32 -0800, Jakub Kicinski wrote:
> > On Mon, 25 Jan 2021 07:09:49 -0800 Eric Dumazet wrote:
> > > From: Eric Dumazet <edumazet@google.com>
> > >
> > > net/core/tso.c got recent support for USO, and this broke iwlfifi
> > > because the driver implemented a limited form of GSO.
> > >
> > > Providing ->gso_type allows for skb_is_gso_tcp() to provide
> > > a correct result.
> > >
> > > Fixes: 3d5b459ba0e3 ("net: tso: add UDP segmentation support")
> > > Signed-off-by: Eric Dumazet <edumazet@google.com>
> > > Reported-by: Ben Greear <greearb@candelatech.com>
> > > Bisected-by: Ben Greear <greearb@candelatech.com>
> > > Tested-by: Ben Greear <greearb@candelatech.com>
> > > Cc: Luca Coelho <luciano.coelho@intel.com>
> > > Cc: linux-wireless@vger.kernel.org
> > > Cc: Johannes Berg <johannes@sipsolutions.net>
> >
> > Johannes, Eric tagged this for net, are you okay with me taking it?
> > No strong preference here.
>
> I guess that really would normally go through Luca's and Kalle's trees,
> but yes, please just take it, it's been long and it won't conflict with
> anything.
Yes, that's fine by me too. Just take it via net and we'll get it into
our trees eventually.
--
Cheers,
Luca.
next prev parent reply other threads:[~2021-01-27 6:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 15:09 [PATCH net] iwlwifi: provide gso_type to GSO packets Eric Dumazet
2021-01-25 15:15 ` Ben Greear
2021-01-25 15:25 ` Eric Dumazet
2021-01-26 20:32 ` Jakub Kicinski
2021-01-26 20:55 ` Johannes Berg
2021-01-27 6:02 ` Coelho, Luciano [this message]
2021-01-26 23:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3aedacff5e5c37a735a2a6da2a8042efcd530eb2.camel@intel.com \
--to=luciano.coelho@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=greearb@candelatech.com \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.