From: Eric Sandeen <sandeen@sandeen.net>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Pavel Reichl <preichl@redhat.com>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/1] xfs: Skip repetitive warnings about mount options
Date: Tue, 23 Feb 2021 15:05:33 -0600 [thread overview]
Message-ID: <3b9366a3-c4ee-a7a0-ea8e-2dc1b3b4c0aa@sandeen.net> (raw)
In-Reply-To: <20210223182517.GM7272@magnolia>
On 2/23/21 12:25 PM, Darrick J. Wong wrote:
>> Ok, yup, I see. so I guess we kind of have:
>>
>> *parsing_mp = fc->s_fs_info;
>>
>> and
>>
>> *current_mp = XFS_M(fc->root->d_sb);
>>
>> (variable names not actually in the code, just used for example)
>
> Maybe they should be. ;)
Yup I almost suggested at least a comment. And since we do care about the
actual/live *mp now, maybe adding self-describing variable names would be a
help.
-Eric
> --D
>
>> Sorry for the noise, my mistake!
>>
>> -Eric
>
prev parent reply other threads:[~2021-02-23 21:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-20 22:15 xfs: Skip repetitive warnings about mount options Pavel Reichl
2021-02-20 22:15 ` [PATCH] xfs: Add test for printing deprec. " Pavel Reichl
2021-02-22 21:22 ` Darrick J. Wong
2021-02-23 16:41 ` Pavel Reichl
2021-02-23 16:54 ` Darrick J. Wong
2021-02-20 22:15 ` [PATCH 1/1] xfs: Skip repetitive warnings about " Pavel Reichl
2021-02-22 21:28 ` Darrick J. Wong
2021-02-23 4:32 ` Dave Chinner
2021-02-22 22:19 ` Eric Sandeen
2021-02-23 17:53 ` Pavel Reichl
2021-02-23 18:10 ` Eric Sandeen
2021-02-23 18:25 ` Darrick J. Wong
2021-02-23 21:05 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b9366a3-c4ee-a7a0-ea8e-2dc1b3b4c0aa@sandeen.net \
--to=sandeen@sandeen.net \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=preichl@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.