From: Giulio Benetti <giulio.benetti@benettiengineering.com>
To: Petr Vorel <pvorel@suse.cz>
Cc: linux-nfs@vger.kernel.org, Petr Vorel <petr.vorel@gmail.com>,
Steve Dickson <steved@redhat.com>
Subject: Re: [PATCH v2] support/backend_sqlite.c: Add missing <sys/syscall.h>
Date: Wed, 6 Dec 2023 23:24:43 +0100 [thread overview]
Message-ID: <3c07e0a6-b797-410c-9cf3-bc5e49a5ca10@benettiengineering.com> (raw)
In-Reply-To: <20231206194220.GA159824@pevik>
Hi Petr,
On 06/12/23 20:42, Petr Vorel wrote:
> Hi Giulio,
>
>> Hi Petr,
>> On 05/12/23 23:35, Petr Vorel wrote:
>>> From: Petr Vorel<petr.vorel@gmail.com>
>>> This fixes build on systems which actually needs getrandom()
>>> (to get SYS_getrandom).
>>> Fixes: f92fd6ca ("support/backend_sqlite.c: Add getrandom() fallback")
>>> Fixes:http://autobuild.buildroot.net/results/c5fde6099a8b228a8bdc3154d1e47dfa192e94ed/
>>> Reported-by: Giulio Benetti<giulio.benetti@benettiengineering.com>
>>> Signed-off-by: Petr Vorel<pvorel@suse.cz>
>> thank you for fixing. I've tested this and the other patch with
>> Buildroot's test-pkg and built fine for many toolchain/arch/libc
>> combinations.
> Thank you for extensive testing! I test only the basic 6 tests (the default
> test-pkg). I suppose you run test-pkg also with -a (these 45 arch
> combinations).
Exactly, I've only found a build failure on util-linux's libmount while
building for sh4+uclibc with bootlin toolchain. See defconfig and log here:
https://pastebin.com/8rxgxvvQ
So that's not due to nfs-utils.
>> Reviewed-by: Giulio Benetti<giulio.benetti@benettiengineering.com>
> Maybe you can add your Tested-by: ?
Sure, good idea.
After running Buildroot utils/test-pkg under Buildroot official docker
using this and previous patch everything built fine except on sh4+uclibc
where util-linux libmount fails(see above). These are the results:
```
br-user@giulio-Ubuntu-HP:/home/giuliobenetti/git/upstream/buildroot$
./utils/test-pkg -p nfs-utils -d test-nfs-utils/ -a
arm-aarch64 [ 1/45]: OK
bootlin-aarch64-glibc [ 2/45]: OK
bootlin-arcle-hs38-uclibc [ 3/45]: OK
bootlin-armv5-uclibc [ 4/45]: OK
bootlin-armv7-glibc [ 5/45]: OK
bootlin-armv7m-uclibc [ 6/45]: SKIPPED
bootlin-armv7-musl [ 7/45]: OK
bootlin-m68k-5208-uclibc [ 8/45]: SKIPPED
bootlin-m68k-68040-uclibc [ 9/45]: OK
bootlin-microblazeel-uclibc [10/45]: OK
bootlin-mipsel32r6-glibc [11/45]: OK
bootlin-mipsel-uclibc [12/45]: OK
bootlin-nios2-glibc [13/45]: OK
bootlin-openrisc-uclibc [14/45]: OK
bootlin-powerpc64le-power8-glibc [15/45]: OK
bootlin-powerpc-e500mc-uclibc [16/45]: OK
bootlin-riscv32-glibc [17/45]: OK
bootlin-riscv64-glibc [18/45]: OK
bootlin-riscv64-musl [19/45]: OK
bootlin-s390x-z13-glibc [20/45]: OK
bootlin-sh4-uclibc [21/45]: FAILED
bootlin-sparc64-glibc [22/45]: OK
bootlin-sparc-uclibc [23/45]: OK
bootlin-x86-64-glibc [24/45]: OK
bootlin-x86-64-musl [25/45]: OK
bootlin-x86-64-uclibc [26/45]: OK
bootlin-xtensa-uclibc [27/45]: OK
br-arm-basic [28/45]: OK
br-arm-full-nothread [29/45]: SKIPPED
br-arm-full-static [30/45]: OK
br-i386-pentium4-full [31/45]: OK
br-i386-pentium-mmx-musl [32/45]: OK
br-mips64-n64-full [33/45]: OK
br-mips64r6-el-hf-glibc [34/45]: OK
br-powerpc-603e-basic-cpp [35/45]: OK
br-powerpc64-power7-glibc [36/45]: OK
linaro-aarch64-be [37/45]: OK
linaro-aarch64 [38/45]: OK
linaro-arm [39/45]: OK
sourcery-arm-armv4t [40/45]: SKIPPED
sourcery-arm [41/45]: SKIPPED
sourcery-arm-thumb2 [42/45]: SKIPPED
sourcery-mips64 [43/45]: OK
sourcery-mips [44/45]: OK
sourcery-nios2 [45/45]: OK
45 builds, 6 skipped, 1 build failed, 0 legal-info failed, 0 show-info
failed
```
So:
Tested-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Kind regards
--
Giulio Benetti
CEO&CTO@Benetti Engineering sas
next prev parent reply other threads:[~2023-12-06 22:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 22:35 [PATCH v2] reexport/{fsidd,reexport}.c: Re-add missing includes Petr Vorel
2023-12-05 22:35 ` [PATCH v2] support/backend_sqlite.c: Add missing <sys/syscall.h> Petr Vorel
2023-12-06 18:53 ` Giulio Benetti
2023-12-06 19:42 ` Petr Vorel
2023-12-06 22:24 ` Giulio Benetti [this message]
2023-12-06 18:53 ` [PATCH v2] reexport/{fsidd,reexport}.c: Re-add missing includes Giulio Benetti
2023-12-06 22:24 ` Giulio Benetti
2024-01-04 0:39 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c07e0a6-b797-410c-9cf3-bc5e49a5ca10@benettiengineering.com \
--to=giulio.benetti@benettiengineering.com \
--cc=linux-nfs@vger.kernel.org \
--cc=petr.vorel@gmail.com \
--cc=pvorel@suse.cz \
--cc=steved@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.