From: Jan Beulich <jbeulich@suse.com>
To: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>
Cc: "Paul Durrant" <paul@xen.org>,
"Roger Pau Monné" <roger.pau@citrix.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2 5/9] IOMMU: add common API for device reserved memory
Date: Mon, 18 Jul 2022 13:15:39 +0200 [thread overview]
Message-ID: <3c273983-bac7-ef14-efc6-5e729d1605a6@suse.com> (raw)
In-Reply-To: <YtU+BbncwbW2+X16@mail-itl>
On 18.07.2022 13:03, Marek Marczykowski-Górecki wrote:
> On Thu, Jul 14, 2022 at 12:17:53PM +0200, Jan Beulich wrote:
>> On 06.07.2022 17:32, Marek Marczykowski-Górecki wrote:
>>> +};
>>> +static unsigned int __initdata nr_extra_reserved_ranges;
>>> +static struct extra_reserved_range __initdata extra_reserved_ranges[MAX_EXTRA_RESERVED_RANGES];
>>
>> Overly long line.
>
> I can't find what coding style dictate in such case. Should the second
> line be indented (and how much)?
I'd recommend
static struct extra_reserved_range __initdata
extra_reserved_ranges[MAX_EXTRA_RESERVED_RANGES];
Jan
next prev parent reply other threads:[~2022-07-18 11:16 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 15:32 [PATCH v2 0/9] Add Xue - console over USB 3 Debug Capability Marek Marczykowski-Górecki
2022-07-06 15:32 ` [PATCH v2 1/9] drivers/char: Add support for Xue USB3 debugger Marek Marczykowski-Górecki
2022-07-08 2:11 ` Marek Marczykowski-Górecki
2022-07-12 15:59 ` Jan Beulich
2022-07-18 10:45 ` Marek Marczykowski-Górecki
2022-07-18 10:55 ` Jan Beulich
2022-07-12 16:06 ` Jan Beulich
2022-07-14 6:05 ` Jan Beulich
2022-07-16 22:40 ` Marek Marczykowski-Górecki
2022-07-14 11:58 ` Jan Beulich
2022-07-16 23:32 ` Marek Marczykowski-Górecki
2022-07-20 20:12 ` Marek Marczykowski-Górecki
2022-07-21 10:25 ` Jan Beulich
2022-07-06 15:32 ` [PATCH v2 2/9] xue: reset XHCI ports when initializing dbc Marek Marczykowski-Górecki
2022-07-13 7:19 ` Jan Beulich
2022-07-06 15:32 ` [PATCH v2 3/9] xue: add support for selecting specific xhci Marek Marczykowski-Górecki
2022-07-13 7:24 ` Jan Beulich
2022-07-06 15:32 ` [PATCH v2 4/9] console: support multiple serial console simultaneously Marek Marczykowski-Górecki
2022-07-13 9:39 ` Jan Beulich
2022-07-18 12:48 ` Marek Marczykowski-Górecki
2022-07-18 14:37 ` Jan Beulich
2022-07-06 15:32 ` [PATCH v2 5/9] IOMMU: add common API for device reserved memory Marek Marczykowski-Górecki
2022-07-14 10:17 ` Jan Beulich
2022-07-18 10:53 ` Marek Marczykowski-Górecki
2022-07-18 11:14 ` Jan Beulich
2022-07-18 11:03 ` Marek Marczykowski-Górecki
2022-07-18 11:15 ` Jan Beulich [this message]
2022-07-06 15:32 ` [PATCH v2 6/9] IOMMU/VT-d: wire common device reserved memory API Marek Marczykowski-Górecki
2022-07-06 15:32 ` [PATCH v2 7/9] IOMMU/AMD: " Marek Marczykowski-Górecki
2022-07-14 10:22 ` Jan Beulich
2022-07-18 11:35 ` Marek Marczykowski-Górecki
2022-07-18 11:44 ` Jan Beulich
2022-07-06 15:32 ` [PATCH v2 8/9] xue: mark DMA buffers as reserved for the device Marek Marczykowski-Górecki
2022-07-14 11:51 ` Jan Beulich
2022-07-18 13:15 ` Marek Marczykowski-Górecki
2022-07-20 20:17 ` Marek Marczykowski-Górecki
2022-07-21 10:30 ` Jan Beulich
2022-07-06 15:32 ` [PATCH v2 9/9] xue: allow driving the rest of XHCI by a domain while Xen uses DbC Marek Marczykowski-Górecki
2022-07-14 12:06 ` Jan Beulich
2022-07-18 12:54 ` Marek Marczykowski-Górecki
2022-07-18 15:07 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c273983-bac7-ef14-efc6-5e729d1605a6@suse.com \
--to=jbeulich@suse.com \
--cc=marmarek@invisiblethingslab.com \
--cc=paul@xen.org \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.